* [Qemu-devel] [PATCH] vga: fix region checks in wraparound case
@ 2017-10-30 10:28 Gerd Hoffmann
2017-10-30 15:05 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 2+ messages in thread
From: Gerd Hoffmann @ 2017-10-30 10:28 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann, Dr. David Alan Gilbert
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/display/vga.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/display/vga.c b/hw/display/vga.c
index 1d19f6b..a64a094 100644
--- a/hw/display/vga.c
+++ b/hw/display/vga.c
@@ -1666,9 +1666,9 @@ static void vga_draw_graphic(VGACommonState *s, int full_update)
/* scanline wraps from end of video memory to the start */
assert(force_shadow);
update = memory_region_snapshot_get_dirty(&s->vram, snap,
- page0, 0);
+ page0, s->vbe_size - page0);
update |= memory_region_snapshot_get_dirty(&s->vram, snap,
- page1, 0);
+ 0, page1);
} else {
update = memory_region_snapshot_get_dirty(&s->vram, snap,
page0, page1 - page0);
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] vga: fix region checks in wraparound case
2017-10-30 10:28 [Qemu-devel] [PATCH] vga: fix region checks in wraparound case Gerd Hoffmann
@ 2017-10-30 15:05 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 2+ messages in thread
From: Dr. David Alan Gilbert @ 2017-10-30 15:05 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel
* Gerd Hoffmann (kraxel@redhat.com) wrote:
> Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Makes more sense to me;
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> hw/display/vga.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/display/vga.c b/hw/display/vga.c
> index 1d19f6b..a64a094 100644
> --- a/hw/display/vga.c
> +++ b/hw/display/vga.c
> @@ -1666,9 +1666,9 @@ static void vga_draw_graphic(VGACommonState *s, int full_update)
> /* scanline wraps from end of video memory to the start */
> assert(force_shadow);
> update = memory_region_snapshot_get_dirty(&s->vram, snap,
> - page0, 0);
> + page0, s->vbe_size - page0);
> update |= memory_region_snapshot_get_dirty(&s->vram, snap,
> - page1, 0);
> + 0, page1);
> } else {
> update = memory_region_snapshot_get_dirty(&s->vram, snap,
> page0, page1 - page0);
> --
> 2.9.3
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-30 15:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-30 10:28 [Qemu-devel] [PATCH] vga: fix region checks in wraparound case Gerd Hoffmann
2017-10-30 15:05 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).