From: Jeff Cody <jcody@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-iotests: Use -nographic in 182
Date: Mon, 30 Oct 2017 16:11:06 +0100 [thread overview]
Message-ID: <20171030151106.GD3549@localhost.localdomain> (raw)
In-Reply-To: <20171029125338.25988-1-kwolf@redhat.com>
On Sun, Oct 29, 2017 at 01:53:38PM +0100, Kevin Wolf wrote:
> This avoids that random UI frontend error messages end up in the output.
> In particular, we were seeing this line in CI error logs:
>
> +Unable to init server: Could not connect: Connection refused
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> tests/qemu-iotests/182 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/182 b/tests/qemu-iotests/182
> index 2e078ceed8..4b31592fb8 100755
> --- a/tests/qemu-iotests/182
> +++ b/tests/qemu-iotests/182
> @@ -62,7 +62,7 @@ _launch_qemu -drive file=$TEST_IMG,if=none,id=drive0,file.locking=on \
>
> echo
> echo "Starting a second QEMU using the same image should fail"
> -echo 'quit' | $QEMU -monitor stdio \
> +echo 'quit' | $QEMU -nographic -monitor stdio \
> -drive file=$TEST_IMG,if=none,id=drive0,file.locking=on \
> -device $virtioblk,drive=drive0 2>&1 | _filter_testdir 2>&1 |
> _filter_qemu |
> --
> 2.13.6
>
>
Reviewed-by: Jeff Cody <jcody@redhat.com>
prev parent reply other threads:[~2017-10-30 15:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-29 12:53 [Qemu-devel] [PATCH] qemu-iotests: Use -nographic in 182 Kevin Wolf
2017-10-30 8:39 ` Kashyap Chamarthy
2017-10-30 10:13 ` Kevin Wolf
2017-10-30 13:54 ` Kashyap Chamarthy
2017-10-30 15:11 ` Jeff Cody [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171030151106.GD3549@localhost.localdomain \
--to=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).