qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
To: qemu-devel@nongnu.org
Cc: dovgaluk@ispras.ru
Subject: [Qemu-devel] [RFCPATCH04/20] replay: fix processing async events
Date: Tue, 31 Oct 2017 13:48:02 +0300	[thread overview]
Message-ID: <20171031104802.3079.79946.stgit@pasha-VirtualBox> (raw)
In-Reply-To: <20171031104741.3079.26584.stgit@pasha-VirtualBox>

Asynchronous events saved at checkpoints may invoke
callbacks when processed. These callbacks may also generate/read
new events (e.g. clock reads). Therefore event processing flag must be
reset before callback invocation.

Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
---
 replay/replay-events.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/replay/replay-events.c b/replay/replay-events.c
index 94a6dcc..768b505 100644
--- a/replay/replay-events.c
+++ b/replay/replay-events.c
@@ -295,13 +295,13 @@ void replay_read_events(int checkpoint)
         if (!event) {
             break;
         }
+        replay_finish_event();
+        read_event_kind = -1;
         replay_mutex_unlock();
         replay_run_event(event);
         replay_mutex_lock();
 
         g_free(event);
-        replay_finish_event();
-        read_event_kind = -1;
     }
 }
 

  parent reply	other threads:[~2017-10-31 10:48 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-31 10:47 [Qemu-devel] [RFCPATCH00/20] replay additions Pavel Dovgalyuk
2017-10-31 10:47 ` [Qemu-devel] [RFCPATCH01/20] block: implement bdrv_snapshot_goto for blkreplay Pavel Dovgalyuk
2017-10-31 10:47 ` [Qemu-devel] [RFCPATCH02/20] blkreplay: create temporary overlay for underlaying devices Pavel Dovgalyuk
2017-10-31 10:47 ` [Qemu-devel] [RFCPATCH03/20] replay: disable default snapshot for record/replay Pavel Dovgalyuk
2017-10-31 10:48 ` Pavel Dovgalyuk [this message]
2017-10-31 10:48 ` [Qemu-devel] [RFCPATCH05/20] replay: fixed replay_enable_events Pavel Dovgalyuk
2017-10-31 10:48 ` [Qemu-devel] [RFCPATCH06/20] replay: fix save/load vm for non-empty queue Pavel Dovgalyuk
2017-10-31 11:21   ` no-reply
2017-10-31 12:13   ` no-reply
2017-10-31 13:26   ` no-reply
2017-10-31 16:41   ` no-reply
2017-10-31 10:48 ` [Qemu-devel] [RFCPATCH07/20] replay: added replay log format description Pavel Dovgalyuk
2017-10-31 10:48 ` [Qemu-devel] [RFCPATCH08/20] replay: make safe vmstop at record/replay Pavel Dovgalyuk
2017-10-31 10:48 ` [Qemu-devel] [RFCPATCH09/20] replay: save prior value of the host clock Pavel Dovgalyuk
2017-10-31 10:48 ` [Qemu-devel] [RFCPATCH10/20] icount: fixed saving/restoring of icount warp timers Pavel Dovgalyuk
2017-10-31 12:47   ` no-reply
2017-10-31 10:48 ` [Qemu-devel] [RFCPATCH11/20] target/arm/arm-powertctl: drop BQL assertions Pavel Dovgalyuk
2017-10-31 10:48 ` [Qemu-devel] [RFCPATCH12/20] cpus: push BQL lock to qemu_*_wait_io_event Pavel Dovgalyuk
2017-10-31 10:48 ` [Qemu-devel] [RFCPATCH13/20] cpus: only take BQL for sleeping threads Pavel Dovgalyuk
2017-10-31 10:48 ` [Qemu-devel] [RFCPATCH14/20] replay/replay.c: bump REPLAY_VERSION again Pavel Dovgalyuk
2017-10-31 10:49 ` [Qemu-devel] [RFCPATCH15/20] replay/replay-internal.c: track holding of replay_lock Pavel Dovgalyuk
2017-10-31 10:49 ` [Qemu-devel] [RFCPATCH16/20] replay: make locking visible outside replay code Pavel Dovgalyuk
2017-10-31 10:49 ` [Qemu-devel] [RFCPATCH17/20] replay: push replay_mutex_lock up the call tree Pavel Dovgalyuk
2017-10-31 10:49 ` [Qemu-devel] [RFCPATCH18/20] cpu-exec: don't overwrite exception_index Pavel Dovgalyuk
2017-10-31 10:49 ` [Qemu-devel] [RFCPATCH19/20] cpu-exec: reset exit flag before calling cpu_exec_nocache Pavel Dovgalyuk
2017-10-31 10:49 ` [Qemu-devel] [RFCPATCH20/20] replay: don't destroy mutex at exit Pavel Dovgalyuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171031104802.3079.79946.stgit@pasha-VirtualBox \
    --to=pavel.dovgaluk@ispras.ru \
    --cc=dovgaluk@ispras.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).