qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: riku.voipio@iki.fi, Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH 3/7] linux-user/hppa: Fix cpu_clone_regs
Date: Tue, 31 Oct 2017 13:53:54 +0100	[thread overview]
Message-ID: <20171031125358.23377-4-richard.henderson@linaro.org> (raw)
In-Reply-To: <20171031125358.23377-1-richard.henderson@linaro.org>

From: Richard Henderson <rth@twiddle.net>

By failing to return from the syscall in the child, the child
issues another clone syscall and hilarity ensues.

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 linux-user/hppa/target_cpu.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/linux-user/hppa/target_cpu.h b/linux-user/hppa/target_cpu.h
index 1a5cecad3c..e50522eae9 100644
--- a/linux-user/hppa/target_cpu.h
+++ b/linux-user/hppa/target_cpu.h
@@ -24,7 +24,11 @@ static inline void cpu_clone_regs(CPUHPPAState *env, target_ulong newsp)
     if (newsp) {
         env->gr[30] = newsp;
     }
+    /* Indicate child in return value.  */
     env->gr[28] = 0;
+    /* Return from the syscall.  */
+    env->iaoq_f = env->gr[31];
+    env->iaoq_b = env->gr[31] + 4;
 }
 
 static inline void cpu_set_tls(CPUHPPAState *env, target_ulong newtls)
-- 
2.13.6

  parent reply	other threads:[~2017-10-31 12:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-31 12:53 [Qemu-devel] [PATCH 0/7] linux-user fixes, mostly for hppa Richard Henderson
2017-10-31 12:53 ` [Qemu-devel] [PATCH 1/7] linux-user: Restrict usage of sa_restorer Richard Henderson
2017-10-31 12:53 ` [Qemu-devel] [PATCH 2/7] linux-user/hppa: Fix TARGET_SA_* defines Richard Henderson
2017-10-31 12:53 ` Richard Henderson [this message]
2017-10-31 12:53 ` [Qemu-devel] [PATCH 4/7] linux-user/hppa: Fix typo for TARGET_NR_epoll_wait Richard Henderson
2017-10-31 12:53 ` [Qemu-devel] [PATCH 5/7] linux-user/hppa: Fix TARGET_MAP_TYPE Richard Henderson
2017-10-31 12:53 ` [Qemu-devel] [PATCH 6/7] linux-user/hppa: Fix TARGET_F_RDLCK, TARGET_F_WRLCK, TARGET_F_UNLCK Richard Henderson
2017-10-31 12:53 ` [Qemu-devel] [PATCH 7/7] linux-user: Handle TARGET_MAP_STACK and TARGET_MAP_HUGETLB Richard Henderson
2017-11-06 19:51 ` [Qemu-devel] [PATCH 0/7] linux-user fixes, mostly for hppa Riku Voipio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171031125358.23377-4-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).