Re: [Qemu-devel] [PATCH 0/5 v2] CAN bus support for QEMU (SJA1000 PCI so far)

[Pavel Pisa <pisa@cmp.felk.cvut.cz>]

Hello Philippe,

On Thursday 02 of November 2017 02:27:18 Philippe Mathieu-Daudé wrote:
> On 11/01/2017 10:00 PM, pisa@cmp.felk.cvut.cz wrote:
> > Some page about the project
> >
> >   https://gitlab.fel.cvut.cz/canbus/qemu-canbus/wikis/home
> >
> > FEE CTU GitLab repository with can-pci branch for 2.3, 2.4, 2.7, 2.8 and
> > 2.10 version if QEMU is available there
> >
> >   https://gitlab.fel.cvut.cz/canbus/qemu-canbus/tree/can-pci
>
> This GitLab seems to be restricted to your university :(

Thanks fort the report, I have moved work from GitHub to local GitLab
for future continuous integration support.

Repository has been public from beginning, but I forgot
to make wiki public. It should be OK now.

Unfortunately, my attempt to follow suggestion to ensure
that even conditionalized debug code is build always
leads to patchew.org problem report because now exposed
static function is not used in non Linux builds

/tmp/qemu-test/src/hw/can/can_core.c:153:13: error: 'can_display_msg' defined but not used [-Werror=unused-function]
 static void can_display_msg(struct qemu_can_frame *msg)
             ^~~~~~~~~~~~~~~
cc1: all warnings being treated as errors


It is used for connection to the host CAN bus interface
and that is implemented only for SocketCAN on Linux.

So patches v3 series is necessary anyway.

I would be happy if I receive some review remarks
for this reorganized series to lower iteration count.

Thanks in advance,

Pavel