From: <jiang.biao2@zte.com.cn>
To: rth@twiddle.net
Cc: aurelien@aurel32.net, qemu-devel@nongnu.org, zhong.weidong@zte.com.cn
Subject: Re: [Qemu-devel] [PATCH] tcg/mips: make some functions inline.
Date: Thu, 2 Nov 2017 19:23:50 +0800 (CST) [thread overview]
Message-ID: <201711021923504024201@zte.com.cn> (raw)
In-Reply-To: <f4e7a6b9-7cdc-b986-2edb-c361622a23a7@twiddle.net>
> On 11/02/2017 11:26 AM, Jiang Biao wrote:> > Make some functions inline.
>
> Why?
>
> Do you have evidence that the compiler isn't making reasonable default choices
> with respect to inlining?
No, :) Just found some of these functions are inline and others are not when reading
the code, the style looks inconsistent.
Besides, The compiler may make default inline choices for some functions, but may
not for some cases(some longer ones). Adding inline manually can guarantee and
not hurt. :)
Thanks.
r~
next prev parent reply other threads:[~2017-11-02 11:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 10:26 [Qemu-devel] [PATCH] tcg/mips: make some functions inline Jiang Biao
2017-11-02 10:53 ` Richard Henderson
2017-11-02 11:23 ` jiang.biao2 [this message]
2017-11-02 11:43 ` Richard Henderson
2017-11-02 12:16 ` Philippe Mathieu-Daudé
2017-11-03 0:37 ` jiang.biao2
2017-11-03 8:42 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201711021923504024201@zte.com.cn \
--to=jiang.biao2@zte.com.cn \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=zhong.weidong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).