From: "Daniel P. Berrange" <berrange@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: Thomas Huth <thuth@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
Max Reitz <mreitz@redhat.com>,
"R . Nageswara Sastry" <nasastry@in.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v2 7/7] qcow2: Assert that the crypto header does not overlap other metadata
Date: Fri, 3 Nov 2017 14:21:44 +0000 [thread overview]
Message-ID: <20171103142144.GJ20155@redhat.com> (raw)
In-Reply-To: <ae3d77f312fc0c5e0ac2bbd71676c0112eebe2e5.1509718618.git.berto@igalia.com>
On Fri, Nov 03, 2017 at 04:18:56PM +0200, Alberto Garcia wrote:
> The crypto header is initialized only when QEMU is creating a new
> image, so there's no chance of this happening on a corrupted image.
>
> If QEMU is really trying to allocate the header overlapping other
> existing metadata sections then this is a serious bug in QEMU itself
> so let's add an assertion.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> block/qcow2.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2017-11-03 14:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 14:18 [Qemu-devel] [PATCH v2 0/7] Misc qcow2 corruption checks Alberto Garcia
2017-11-03 14:18 ` [Qemu-devel] [PATCH v2 1/7] qcow2: Prevent allocating refcount blocks at offset 0 Alberto Garcia
2017-11-03 14:18 ` [Qemu-devel] [PATCH v2 2/7] qcow2: Prevent allocating L2 tables " Alberto Garcia
2017-11-03 14:18 ` [Qemu-devel] [PATCH v2 3/7] qcow2: Prevent allocating compressed clusters " Alberto Garcia
2017-11-03 16:27 ` Max Reitz
2017-11-03 20:22 ` Alberto Garcia
2017-11-03 20:32 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2017-11-06 12:36 ` Max Reitz
2017-11-06 12:52 ` Alberto Garcia
2017-11-03 14:18 ` [Qemu-devel] [PATCH v2 4/7] qcow2: Don't open images with header.refcount_table_clusters == 0 Alberto Garcia
2017-11-07 16:43 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
2017-11-08 9:55 ` Alberto Garcia
2017-11-03 14:18 ` [Qemu-devel] [PATCH v2 5/7] qcow2: Add iotest for an image with header.refcount_table_offset " Alberto Garcia
2017-11-03 16:36 ` Max Reitz
2017-11-03 14:18 ` [Qemu-devel] [PATCH v2 6/7] qcow2: Add iotest for an empty refcount table Alberto Garcia
2017-11-03 14:18 ` [Qemu-devel] [PATCH v2 7/7] qcow2: Assert that the crypto header does not overlap other metadata Alberto Garcia
2017-11-03 14:21 ` Daniel P. Berrange [this message]
2017-11-03 16:37 ` [Qemu-devel] [PATCH v2 0/7] Misc qcow2 corruption checks Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171103142144.GJ20155@redhat.com \
--to=berrange@redhat.com \
--cc=berto@igalia.com \
--cc=mreitz@redhat.com \
--cc=nasastry@in.ibm.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).