From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47030) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAcr6-0004Vz-ED for qemu-devel@nongnu.org; Fri, 03 Nov 2017 10:21:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eAcr5-00018W-A6 for qemu-devel@nongnu.org; Fri, 03 Nov 2017 10:21:56 -0400 Date: Fri, 3 Nov 2017 14:21:44 +0000 From: "Daniel P. Berrange" Message-ID: <20171103142144.GJ20155@redhat.com> Reply-To: "Daniel P. Berrange" References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2 7/7] qcow2: Assert that the crypto header does not overlap other metadata List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: Thomas Huth , qemu-block@nongnu.org, qemu-devel@nongnu.org, Max Reitz , "R . Nageswara Sastry" On Fri, Nov 03, 2017 at 04:18:56PM +0200, Alberto Garcia wrote: > The crypto header is initialized only when QEMU is creating a new > image, so there's no chance of this happening on a corrupted image. > > If QEMU is really trying to allocate the header overlapping other > existing metadata sections then this is a serious bug in QEMU itself > so let's add an assertion. > > Signed-off-by: Alberto Garcia > --- > block/qcow2.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|