Re: [Qemu-devel] [PATCH v4] pci: Set err to errp directly rather than through error_propagate()

[Stefan Hajnoczi <stefanha@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]

On Thu, Oct 12, 2017 at 10:44:26AM +0800, Mao Zhongyi wrote:
> On 09/12/2017 06:16 PM, Stefan Hajnoczi wrote:
> > On Sat, Sep 09, 2017 at 02:22:26PM +0800, Mao Zhongyi wrote:
> > > ioh3420_interrupts_init() pass error message to local_err, then
> > > propagate it to errp by error_propagate(), which is not necessary.
> > > So eliminate it and pass errp directly instead of local_err.
> > > 
> > > Cc: "Michael S. Tsirkin" <mst@redhat.com>
> > > Cc: Marcel Apfelbaum <marcel@redhat.com>
> > > Signed-off-by: Mao Zhongyi <maozy.fnst@cn.fujitsu.com>
> > > Reviewed-by: Eric Blake <eblake@redhat.com>
> > > Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
> > > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > > ---
> > > v4:
> > > it not apply clearly on HEAD, so rebase it and modify the commit
> > > message.
> > > ---
> > > 
> > >  hw/pci-bridge/ioh3420.c | 4 +---
> > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> 
> Hi,
> 
> Long time no news. Ping...

This patch should go through Michael Tsirkin's tree.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]