* [Qemu-devel] [PATCH v4] pci: Set err to errp directly rather than through error_propagate()
@ 2017-09-09 6:22 Mao Zhongyi
2017-09-12 10:16 ` Stefan Hajnoczi
0 siblings, 1 reply; 5+ messages in thread
From: Mao Zhongyi @ 2017-09-09 6:22 UTC (permalink / raw)
To: qemu-devel; +Cc: Michael S. Tsirkin, Marcel Apfelbaum
ioh3420_interrupts_init() pass error message to local_err, then
propagate it to errp by error_propagate(), which is not necessary.
So eliminate it and pass errp directly instead of local_err.
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Marcel Apfelbaum <marcel@redhat.com>
Signed-off-by: Mao Zhongyi <maozy.fnst@cn.fujitsu.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
v4:
it not apply clearly on HEAD, so rebase it and modify the commit
message.
---
hw/pci-bridge/ioh3420.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/pci-bridge/ioh3420.c b/hw/pci-bridge/ioh3420.c
index da4e5bd..5f56a2f 100644
--- a/hw/pci-bridge/ioh3420.c
+++ b/hw/pci-bridge/ioh3420.c
@@ -64,15 +64,13 @@ static uint8_t ioh3420_aer_vector(const PCIDevice *d)
static int ioh3420_interrupts_init(PCIDevice *d, Error **errp)
{
int rc;
- Error *local_err = NULL;
rc = msi_init(d, IOH_EP_MSI_OFFSET, IOH_EP_MSI_NR_VECTOR,
IOH_EP_MSI_SUPPORTED_FLAGS & PCI_MSI_FLAGS_64BIT,
IOH_EP_MSI_SUPPORTED_FLAGS & PCI_MSI_FLAGS_MASKBIT,
- &local_err);
+ errp);
if (rc < 0) {
assert(rc == -ENOTSUP);
- error_propagate(errp, local_err);
}
return rc;
--
2.9.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH v4] pci: Set err to errp directly rather than through error_propagate()
2017-09-09 6:22 [Qemu-devel] [PATCH v4] pci: Set err to errp directly rather than through error_propagate() Mao Zhongyi
@ 2017-09-12 10:16 ` Stefan Hajnoczi
2017-10-12 2:44 ` Mao Zhongyi
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Hajnoczi @ 2017-09-12 10:16 UTC (permalink / raw)
To: Mao Zhongyi; +Cc: qemu-devel, Marcel Apfelbaum, Michael S. Tsirkin
On Sat, Sep 09, 2017 at 02:22:26PM +0800, Mao Zhongyi wrote:
> ioh3420_interrupts_init() pass error message to local_err, then
> propagate it to errp by error_propagate(), which is not necessary.
> So eliminate it and pass errp directly instead of local_err.
>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Marcel Apfelbaum <marcel@redhat.com>
> Signed-off-by: Mao Zhongyi <maozy.fnst@cn.fujitsu.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> v4:
> it not apply clearly on HEAD, so rebase it and modify the commit
> message.
> ---
>
> hw/pci-bridge/ioh3420.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v4] pci: Set err to errp directly rather than through error_propagate()
2017-09-12 10:16 ` Stefan Hajnoczi
@ 2017-10-12 2:44 ` Mao Zhongyi
2017-11-03 15:10 ` Stefan Hajnoczi
0 siblings, 1 reply; 5+ messages in thread
From: Mao Zhongyi @ 2017-10-12 2:44 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: qemu-devel, Marcel Apfelbaum, Michael S. Tsirkin, Eric Blake,
Philippe Mathieu-Daudé
On 09/12/2017 06:16 PM, Stefan Hajnoczi wrote:
> On Sat, Sep 09, 2017 at 02:22:26PM +0800, Mao Zhongyi wrote:
>> ioh3420_interrupts_init() pass error message to local_err, then
>> propagate it to errp by error_propagate(), which is not necessary.
>> So eliminate it and pass errp directly instead of local_err.
>>
>> Cc: "Michael S. Tsirkin" <mst@redhat.com>
>> Cc: Marcel Apfelbaum <marcel@redhat.com>
>> Signed-off-by: Mao Zhongyi <maozy.fnst@cn.fujitsu.com>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>> Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> v4:
>> it not apply clearly on HEAD, so rebase it and modify the commit
>> message.
>> ---
>>
>> hw/pci-bridge/ioh3420.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>
>
>
Hi,
Long time no news. Ping...
Thanks,
Mao
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v4] pci: Set err to errp directly rather than through error_propagate()
2017-10-12 2:44 ` Mao Zhongyi
@ 2017-11-03 15:10 ` Stefan Hajnoczi
2017-11-06 1:12 ` Mao Zhongyi
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Hajnoczi @ 2017-11-03 15:10 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Marcel Apfelbaum, Philippe Mathieu-Daudé, qemu-devel,
Mao Zhongyi
[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]
On Thu, Oct 12, 2017 at 10:44:26AM +0800, Mao Zhongyi wrote:
> On 09/12/2017 06:16 PM, Stefan Hajnoczi wrote:
> > On Sat, Sep 09, 2017 at 02:22:26PM +0800, Mao Zhongyi wrote:
> > > ioh3420_interrupts_init() pass error message to local_err, then
> > > propagate it to errp by error_propagate(), which is not necessary.
> > > So eliminate it and pass errp directly instead of local_err.
> > >
> > > Cc: "Michael S. Tsirkin" <mst@redhat.com>
> > > Cc: Marcel Apfelbaum <marcel@redhat.com>
> > > Signed-off-by: Mao Zhongyi <maozy.fnst@cn.fujitsu.com>
> > > Reviewed-by: Eric Blake <eblake@redhat.com>
> > > Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
> > > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > > ---
> > > v4:
> > > it not apply clearly on HEAD, so rebase it and modify the commit
> > > message.
> > > ---
> > >
> > > hw/pci-bridge/ioh3420.c | 4 +---
> > > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> Hi,
>
> Long time no news. Ping...
This patch should go through Michael Tsirkin's tree.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v4] pci: Set err to errp directly rather than through error_propagate()
2017-11-03 15:10 ` Stefan Hajnoczi
@ 2017-11-06 1:12 ` Mao Zhongyi
0 siblings, 0 replies; 5+ messages in thread
From: Mao Zhongyi @ 2017-11-06 1:12 UTC (permalink / raw)
To: Stefan Hajnoczi, Michael S. Tsirkin
Cc: Marcel Apfelbaum, Philippe Mathieu-Daudé, qemu-devel
On 11/03/2017 11:10 PM, Stefan Hajnoczi wrote:
> On Thu, Oct 12, 2017 at 10:44:26AM +0800, Mao Zhongyi wrote:
>> On 09/12/2017 06:16 PM, Stefan Hajnoczi wrote:
>>> On Sat, Sep 09, 2017 at 02:22:26PM +0800, Mao Zhongyi wrote:
>>>> ioh3420_interrupts_init() pass error message to local_err, then
>>>> propagate it to errp by error_propagate(), which is not necessary.
>>>> So eliminate it and pass errp directly instead of local_err.
>>>>
>>>> Cc: "Michael S. Tsirkin" <mst@redhat.com>
>>>> Cc: Marcel Apfelbaum <marcel@redhat.com>
>>>> Signed-off-by: Mao Zhongyi <maozy.fnst@cn.fujitsu.com>
>>>> Reviewed-by: Eric Blake <eblake@redhat.com>
>>>> Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
>>>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>> ---
>>>> v4:
>>>> it not apply clearly on HEAD, so rebase it and modify the commit
>>>> message.
>>>> ---
>>>>
>>>> hw/pci-bridge/ioh3420.c | 4 +---
>>>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>>
>>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>>
>> Hi,
>>
>> Long time no news. Ping...
>
> This patch should go through Michael Tsirkin's tree.
Hi, Stefan
Thanks for the info. This patch has merged by Michael S. Tsirkin.
>
> Stefan
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-06 1:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-09 6:22 [Qemu-devel] [PATCH v4] pci: Set err to errp directly rather than through error_propagate() Mao Zhongyi
2017-09-12 10:16 ` Stefan Hajnoczi
2017-10-12 2:44 ` Mao Zhongyi
2017-11-03 15:10 ` Stefan Hajnoczi
2017-11-06 1:12 ` Mao Zhongyi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).