qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Aurelien Jarno <aurelien@aurel32.net>,
	Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
	Stafford Horne <shorne@gmail.com>,
	qemu-arm@nongnu.org, Laurent Vivier <laurent@vivier.eu>
Subject: [Qemu-devel] [PATCH 4/4] softfloat: use floatXX_val() in XX_minmax()
Date: Fri,  3 Nov 2017 21:26:24 +0100	[thread overview]
Message-ID: <20171103202624.5956-5-laurent@vivier.eu> (raw)
In-Reply-To: <20171103202624.5956-1-laurent@vivier.eu>

Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 fpu/softfloat.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fpu/softfloat.c b/fpu/softfloat.c
index 433c5dad2d..331d78e848 100644
--- a/fpu/softfloat.c
+++ b/fpu/softfloat.c
@@ -7700,11 +7700,9 @@ static inline float ## s float ## s ## _minmax(float ## s a, float ## s b,     \
     }                                                                   \
     aSign = extractFloat ## s ## Sign(a);                               \
     bSign = extractFloat ## s ## Sign(b);                               \
-    av = float ## s ## _val(a);                                         \
-    bv = float ## s ## _val(b);                                         \
     if (ismag) {                                                        \
-        aav = float ## s ## _abs(av);                                   \
-        abv = float ## s ## _abs(bv);                                   \
+        aav = float ## s ## _val(float ## s ## _abs(a));                \
+        abv = float ## s ## _val(float ## s ## _abs(b));                \
         if (aav != abv) {                                               \
             if (ismin) {                                                \
                 return (aav < abv) ? a : b;                             \
@@ -7713,6 +7711,8 @@ static inline float ## s float ## s ## _minmax(float ## s a, float ## s b,     \
             }                                                           \
         }                                                               \
     }                                                                   \
+    av = float ## s ## _val(a);                                         \
+    bv = float ## s ## _val(b);                                         \
     if (aSign != bSign) {                                               \
         if (ismin) {                                                    \
             return aSign ? a : b;                                       \
-- 
2.13.6

  parent reply	other threads:[~2017-11-03 20:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03 20:26 [Qemu-devel] [PATCH 0/4] softfloat: fix some helper definitions Laurent Vivier
2017-11-03 20:26 ` [Qemu-devel] [PATCH 1/4] arm: fix float64 " Laurent Vivier
2017-11-07 14:54   ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2017-11-03 20:26 ` [Qemu-devel] [PATCH 2/4] openrisc: fix float32 and " Laurent Vivier
2017-11-04 21:20   ` Stafford Horne
2017-11-05 14:39     ` Laurent Vivier
2017-11-07 10:59       ` Stafford Horne
2017-11-07 14:38   ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2017-11-03 20:26 ` [Qemu-devel] [PATCH 3/4] tricore: use make_float32() and float32_val() Laurent Vivier
2017-11-07 14:40   ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2017-11-03 20:26 ` Laurent Vivier [this message]
2017-11-03 21:27 ` [Qemu-devel] [Qemu-arm] [PATCH 0/4] softfloat: fix some helper definitions Philippe Mathieu-Daudé
2017-11-03 21:51   ` Philippe Mathieu-Daudé
2017-11-04  8:55     ` Laurent Vivier
2017-11-04 16:18       ` Philippe Mathieu-Daudé
2017-11-07 14:52         ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171103202624.5956-5-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=aurelien@aurel32.net \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shorne@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).