From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Longpeng(Mike)" <longpeng2@huawei.com>
Cc: berrange@redhat.com, pbonzini@redhat.com,
arei.gonglei@huawei.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] crypto: afalg: fix a NULL pointer dereference
Date: Mon, 6 Nov 2017 17:18:44 +0000 [thread overview]
Message-ID: <20171106171844.GI4557@stefanha-x1.localdomain> (raw)
In-Reply-To: <1509949271-36280-1-git-send-email-longpeng2@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 719 bytes --]
On Mon, Nov 06, 2017 at 02:21:11PM +0800, Longpeng(Mike) wrote:
> Test-crypto-hash calls qcrypto_hash_bytesv/digest/base64 with
> errp=NULL, this will cause a NULL poniter deference if afalg_driver
> doesn't support requested algos:
> ret = qcrypto_hash_afalg_driver.hash_bytesv(alg, iov, niov,
> result, resultlen,
> errp);
> if (ret == 0) {
> return ret;
> }
>
> error_free(*errp); // <--- here
>
> So we must check 'errp & *errp' before dereference.
Only errp needs to be checked. It's okay to invoke error_free(NULL):
void error_free(Error *err)
{
if (err) {
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-11-06 17:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 6:21 [Qemu-devel] [PATCH] crypto: afalg: fix a NULL pointer dereference Longpeng(Mike)
2017-11-06 10:21 ` Gonglei (Arei)
2017-11-06 17:00 ` Eric Blake
2017-11-07 2:27 ` Longpeng (Mike)
2017-11-07 9:16 ` Daniel P. Berrange
2017-11-07 9:32 ` Longpeng (Mike)
2017-11-06 17:18 ` Stefan Hajnoczi [this message]
2017-11-07 1:13 ` Longpeng (Mike)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106171844.GI4557@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=arei.gonglei@huawei.com \
--cc=berrange@redhat.com \
--cc=longpeng2@huawei.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).