qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kurz <groug@kaod.org>
To: Michael Fritscher <michael@fritscher.net>
Cc: sw@weilnetz.de, aneesh.kumar@linux.vnet.ibm.com, mst@redhat.com,
	qemu-devel@nongnu.org, Greg Kurz <gkurz@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 03/18] Disable the proxy fsdev under Windows.
Date: Mon, 6 Nov 2017 17:51:36 +0100	[thread overview]
Message-ID: <20171106175136.705ff437@bahia> (raw)
In-Reply-To: <5d67c7311aa19c9830cf4927a4e22159.squirrel@mifritscher.de>

On Mon, 6 Nov 2017 16:17:29 +0100
"Michael Fritscher" <michael@fritscher.net> wrote:

> > On Fri, 29 Sep 2017 13:13:08 +0200
> > Michael Fritscher <michael@fritscher.net> wrote:  
> >> Signed-off-by: Michael Fritscher <michael@fritscher.net>  
> >
> > What's the justification for this patch ?  
> It had too much linuxisms in it to fix compiling - so I disabled the proxy
> variant altogether. Reactivating it could be done in a version 2.0 ;-)
> 

That's what I was guessing. Fair enough but it deserves some justification in
the commit log anyway :)

BTW, the main justification for the proxy backend is to provide "extra"
security (the helper chroots into the shared directory). I don't know if
this makes sense on a windows host.

Also, if you go for a windows specific backend as suggested in another
mail, you should probably disable all the other existing backends as
well.

> Best regards,
> Michael Fritscher
> 
> 

  reply	other threads:[~2017-11-06 16:51 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-29 11:13 [Qemu-devel] Make 9pfs buildable for Windows Michael Fritscher
2017-09-29 11:13 ` [Qemu-devel] [PATCH 01/18] Add definitions needed by file-op-9p.h " Michael Fritscher
2017-11-06 13:34   ` Greg Kurz
2017-09-29 11:13 ` [Qemu-devel] [PATCH 02/18] #include <sys/vfs.h> is not available under Windows Michael Fritscher
2017-11-06 14:27   ` Paolo Bonzini
2017-09-29 11:13 ` [Qemu-devel] [PATCH 03/18] Disable the proxy fsdev " Michael Fritscher
2017-11-06 13:44   ` Greg Kurz
2017-11-06 15:17     ` Michael Fritscher
2017-11-06 16:51       ` Greg Kurz [this message]
2017-09-29 11:13 ` [Qemu-devel] [PATCH 04/18] Don't include sys/resource.h on Windows Michael Fritscher
2017-11-06 14:27   ` Paolo Bonzini
2017-09-29 11:13 ` [Qemu-devel] [PATCH 05/18] Add definitions for 9p.c Michael Fritscher
2017-09-29 11:13 ` [Qemu-devel] [PATCH 06/18] Stub out functions for 9pfs Michael Fritscher
2017-09-29 11:13 ` [Qemu-devel] [PATCH 07/18] Fix unused variable error and unsuded function if FS_IOC_GETVERSION is not defined Michael Fritscher
2017-11-06 14:29   ` Paolo Bonzini
2017-09-29 11:13 ` [Qemu-devel] [PATCH 08/18] Stub 9pfs xattr functions for Windows Michael Fritscher
2017-09-29 11:13 ` [Qemu-devel] [PATCH 09/18] Dont initialize fields which aren't available on Windows Michael Fritscher
2017-11-06 14:26   ` Paolo Bonzini
2017-09-29 11:13 ` [Qemu-devel] [PATCH 10/18] dirent has no d_off " Michael Fritscher
2017-09-29 11:13 ` [Qemu-devel] [PATCH 11/18] Sete ctx->xops to null " Michael Fritscher
2017-11-06 14:25   ` Paolo Bonzini
2017-09-29 11:13 ` [Qemu-devel] [PATCH 12/18] Buildfix in 9p-util.c Michael Fritscher
2017-11-06 14:21   ` Paolo Bonzini
2017-09-29 11:13 ` [Qemu-devel] [PATCH 13/18] fsetxattrat_nofollow doesn't seem to be defined on Windows - disable it Michael Fritscher
2017-09-29 11:13 ` [Qemu-devel] [PATCH 14/18] Disable rlimit under Windows Michael Fritscher
2017-11-06 14:24   ` Paolo Bonzini
2017-09-29 11:13 ` [Qemu-devel] [PATCH 15/18] Fix unavailable fields in stbuf " Michael Fritscher
2017-11-06 14:36   ` Paolo Bonzini
2017-11-06 15:23     ` Michael Fritscher
2017-11-06 15:25       ` Paolo Bonzini
2017-09-29 11:13 ` [Qemu-devel] [PATCH 16/18] Workaround for missing dent->d_type/d_off " Michael Fritscher
2017-11-06 14:32   ` Paolo Bonzini
2017-09-29 11:13 ` [Qemu-devel] [PATCH 17/18] Compile fixes for Windows Michael Fritscher
2017-09-29 11:13 ` [Qemu-devel] [PATCH 18/18] Enable 9pfs for Windows in configure / makefiles Michael Fritscher
2017-09-29 12:01 ` [Qemu-devel] Make 9pfs buildable for Windows Paolo Bonzini
2017-09-29 14:14   ` Michael Fritscher
2017-09-29 14:25     ` Paolo Bonzini
2017-09-29 18:09       ` Michael Fritscher
2017-10-01 16:17       ` Michael Fritscher
2017-10-15 19:02       ` Michael Fritscher
2017-10-15 19:13         ` Michael Fritscher
2017-10-15 19:50           ` Greg Kurz
2017-10-15 20:00             ` Michael Fritscher
2017-10-16  5:31             ` Michael Fritscher
2017-10-15 19:45         ` Greg Kurz
2017-11-06 13:29 ` Greg Kurz
2017-11-06 15:14   ` Michael Fritscher
2017-11-06 15:36     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171106175136.705ff437@bahia \
    --to=groug@kaod.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=gkurz@linux.vnet.ibm.com \
    --cc=michael@fritscher.net \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).