From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBnw9-0005lq-Hr for qemu-devel@nongnu.org; Mon, 06 Nov 2017 15:24:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBnw8-0001W5-MP for qemu-devel@nongnu.org; Mon, 06 Nov 2017 15:24:01 -0500 Date: Mon, 6 Nov 2017 15:23:43 -0500 From: Jeff Cody Message-ID: <20171106202343.GA18521@localhost.localdomain> References: <20171103110500.GM5078@stefanha-x1.localdomain> <5d2d57d5-6bac-72df-362c-996a6873ec9b@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5d2d57d5-6bac-72df-362c-996a6873ec9b@openvz.org> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/3] block/parallals: Do not update header or truncate image when INMIGRATE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Stefan Hajnoczi , qemu-block@nongnu.org, kwolf@redhat.com, aik@ozlabs.ru, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com On Fri, Nov 03, 2017 at 02:08:13PM +0300, Denis V. Lunev wrote: > On 11/03/2017 02:05 PM, Stefan Hajnoczi wrote: > > On Mon, Oct 30, 2017 at 02:10:27PM +0100, Jeff Cody wrote: > >> If we write or modify the image file while the QEMU run state is > >> INMIGRATE, then the BDRV_O_INACTIVE BDS flag is set. This will cause > >> an assert, since the image is marked inactive. Make sure we obey this > >> flag. > >> > >> Signed-off-by: Jeff Cody > >> --- > >> block/parallels.c | 7 ++----- > >> 1 file changed, 2 insertions(+), 5 deletions(-) > >> > >> diff --git a/block/parallels.c b/block/parallels.c > >> index 2b6c6e5709..7b7a3efa1d 100644 > >> --- a/block/parallels.c > >> +++ b/block/parallels.c > >> @@ -708,7 +708,7 @@ static int parallels_open(BlockDriverState *bs, QDict *options, int flags, > >> s->prealloc_mode = PRL_PREALLOC_MODE_FALLOCATE; > >> } > >> > >> - if (flags & BDRV_O_RDWR) { > >> + if ((flags & BDRV_O_RDWR) && !(flags & BDRV_O_INACTIVE)) { > >> s->header->inuse = cpu_to_le32(HEADER_INUSE_MAGIC); > >> ret = parallels_update_header(bs); > >> if (ret < 0) { > > Where do we ensure that HEADER_INUSE_MAGIC is set on the destination? > good point. it should be set in invalidate_cache following QCOW2 scheme. > Thus we should add that callback with this patch. > Do we (intentionally) support migration with parallels? I guess so, since it doesn't have migration blockers.