From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBxvU-0001qz-US for qemu-devel@nongnu.org; Tue, 07 Nov 2017 02:04:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBxvR-0002cL-O0 for qemu-devel@nongnu.org; Tue, 07 Nov 2017 02:04:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44458) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eBxvR-0002bw-H1 for qemu-devel@nongnu.org; Tue, 07 Nov 2017 02:03:57 -0500 Date: Tue, 7 Nov 2017 15:03:49 +0800 From: Fam Zheng Message-ID: <20171107070349.GL16355@lemon> References: <20171106094643.14881-1-peterx@redhat.com> <20171106094643.14881-9-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171106094643.14881-9-peterx@redhat.com> Subject: Re: [Qemu-devel] [RFC v3 08/27] monitor: unify global init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , "Daniel P . Berrange" , Paolo Bonzini , Jiri Denemark , Juan Quintela , mdroth@linux.vnet.ibm.com, Eric Blake , Laurent Vivier , marcandre.lureau@redhat.com, Markus Armbruster , "Dr . David Alan Gilbert" On Mon, 11/06 17:46, Peter Xu wrote: > There are many places for monitor init its globals, at least: > > - monitor_init_qmp_commands() at the very beginning > - single function to init monitor_lock > - in the first entry of monitor_init() using "is_first_init" > > Unify them a bit. > > Signed-off-by: Peter Xu Reviewed-by: Fam Zheng