From: Stefan Hajnoczi <stefanha@redhat.com>
To: Jeff Cody <jcody@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, kwolf@redhat.com,
aik@ozlabs.ru, mreitz@redhat.com, den@openvz.org
Subject: Re: [Qemu-devel] [PATCH v3 3/4] block/parallels: add migration blocker
Date: Tue, 7 Nov 2017 10:04:17 +0000 [thread overview]
Message-ID: <20171107100417.GA6809@stefanha-x1.localdomain> (raw)
In-Reply-To: <5d07b67f40f00586834bfc7e6e3adbfcc058e3de.1510021573.git.jcody@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 825 bytes --]
On Mon, Nov 06, 2017 at 09:31:21PM -0500, Jeff Cody wrote:
> @@ -720,6 +722,16 @@ static int parallels_open(BlockDriverState *bs, QDict *options, int flags,
> s->bat_dirty_bmap =
> bitmap_new(DIV_ROUND_UP(s->header_size, s->bat_dirty_block));
>
> + /* Disable migration until bdrv_invalidate_cache method is added */
> + error_setg(&s->migration_blocker, "The Parallels format used by node '%s' "
> + "does not support live migration",
> + bdrv_get_device_or_node_name(bs));
> + ret = migrate_add_blocker(s->migration_blocker, &local_err);
> + if (local_err) {
> + error_propagate(errp, local_err);
> + error_free(s->migration_blocker);
> + goto fail;
> + }
Please call migrate_del_blocker() and error_free() in .bdrv_close().
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-11-07 10:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 2:31 [Qemu-devel] [PATCH v3 0/4] Don't write headers if BDS is INACTIVE Jeff Cody
2017-11-07 2:31 ` [Qemu-devel] [PATCH v3 1/4] block/vhdx.c: Don't blindly update the header Jeff Cody
2017-11-07 2:31 ` [Qemu-devel] [PATCH v3 2/4] block/parallels: Do not update header or truncate image when INMIGRATE Jeff Cody
2017-11-07 2:31 ` [Qemu-devel] [PATCH v3 3/4] block/parallels: add migration blocker Jeff Cody
2017-11-07 10:04 ` Stefan Hajnoczi [this message]
2017-11-07 2:31 ` [Qemu-devel] [PATCH v3 4/4] qemu-iotests: update unsupported image formats in 194 Jeff Cody
2017-11-07 6:00 ` [Qemu-devel] [PATCH v3 0/4] Don't write headers if BDS is INACTIVE Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171107100417.GA6809@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=aik@ozlabs.ru \
--cc=den@openvz.org \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).