qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: QEMU <qemu-devel@nongnu.org>,
	Marcel Apfelbaum <marcel@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Alexander Graf <agraf@suse.de>,
	Stefan Berger <stefanb@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] i440/piix and dynamic sysbus check
Date: Tue, 7 Nov 2017 14:53:39 -0200	[thread overview]
Message-ID: <20171107165339.GB3111@localhost.localdomain> (raw)
In-Reply-To: <CAJ+F1CKWdxAwuZ-QAvT=AhGMrXd+7c8=eBCMMuKPdbK75NDtiQ@mail.gmail.com>

On Tue, Nov 07, 2017 at 05:40:17PM +0100, Marc-André Lureau wrote:
> Hi,
> 
> I am working on a TPM CRB device (last sent version:
> https://lists.gnu.org/archive/html/qemu-devel/2017-10/msg02014.html).
> It's a sysbus device, and when starting qemu with i440, I get "Option
> '-device tpm-crb' cannot be handled by this machine".
> 
> The check comes from machine_init_notify(), checking that the machine
> has_dynamic_sysbus.
> 
>  Apparently, q35 supports it. But not i440. If I declare
> has_dynamic_sysbus in piix, the device works fine.

Before doing that, I would like to replace has_dynamic_sysbus
with a whitelist, so we don't need to make the machine accept all
other sysbus devices too.

I probably should rebase and resubmit this RFC:
http://mid.mail-archive.com/20170323212848.8492-1-ehabkost@redhat.com
Subject: [Qemu-devel] [RFC 0/4] Replace has_dynamic_sysbus with device type  whitelist


> 
> Marcel, could we do something similar to piix to what you did for q35?:
> 
> commit bf8d492405feaee2c1685b3b9d5e03228ed3e47f
> Author: Marcel Apfelbaum <marcel@redhat.com>
> Date:   Mon Jun 27 18:38:33 2016 +0300
> 
>     q35: allow dynamic sysbus
> 
> thanks
> 
> -- 
> Marc-André Lureau

-- 
Eduardo

  reply	other threads:[~2017-11-07 16:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-07 16:40 [Qemu-devel] i440/piix and dynamic sysbus check Marc-André Lureau
2017-11-07 16:53 ` Eduardo Habkost [this message]
2017-11-08  6:54   ` Marc-André Lureau
2017-11-08  8:57 ` Marcel Apfelbaum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171107165339.GB3111@localhost.localdomain \
    --to=ehabkost@redhat.com \
    --cc=agraf@suse.de \
    --cc=marcandre.lureau@gmail.com \
    --cc=marcel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).