* [Qemu-devel] [PATCH] docker: correctly escape $BACKEND in the help output
@ 2017-11-08 2:47 Philippe Mathieu-Daudé
2017-11-08 3:00 ` Fam Zheng
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-11-08 2:47 UTC (permalink / raw)
To: Alex Bennée, Daniel P . Berrange, Fam Zheng
Cc: Philippe Mathieu-Daudé, qemu-devel, qemu-trivial
In Makefiles the $ must be escaped as $$ in shell uses.
Since 8a2390a4f47:
$ make docker
[...]
NETWORK=1 Enable virtual network interface with default backend.
NETWORK=ACKEND Enable virtual network interface with ACKEND.
Once escaped:
$ make docker
[...]
NETWORK=1 Enable virtual network interface with default backend.
NETWORK=$BACKEND Enable virtual network interface with $BACKEND.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
tests/docker/Makefile.include | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index f1a398e9fa..de87341528 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -109,7 +109,7 @@ docker:
@echo ' DEBUG=1 Stop and drop to shell in the created container'
@echo ' before running the command.'
@echo ' NETWORK=1 Enable virtual network interface with default backend.'
- @echo ' NETWORK=$BACKEND Enable virtual network interface with $BACKEND.'
+ @echo ' NETWORK=$$BACKEND Enable virtual network interface with $$BACKEND.'
@echo ' NOUSER Define to disable adding current user to containers passwd.'
@echo ' NOCACHE=1 Ignore cache when build images.'
@echo ' EXECUTABLE=<path> Include executable in image.'
--
2.15.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] docker: correctly escape $BACKEND in the help output
2017-11-08 2:47 [Qemu-devel] [PATCH] docker: correctly escape $BACKEND in the help output Philippe Mathieu-Daudé
@ 2017-11-08 3:00 ` Fam Zheng
0 siblings, 0 replies; 2+ messages in thread
From: Fam Zheng @ 2017-11-08 3:00 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Alex Bennée, Daniel P . Berrange, qemu-trivial, qemu-devel
On Tue, 11/07 23:47, Philippe Mathieu-Daudé wrote:
> In Makefiles the $ must be escaped as $$ in shell uses.
>
> Since 8a2390a4f47:
>
> $ make docker
> [...]
> NETWORK=1 Enable virtual network interface with default backend.
> NETWORK=ACKEND Enable virtual network interface with ACKEND.
>
> Once escaped:
>
> $ make docker
> [...]
> NETWORK=1 Enable virtual network interface with default backend.
> NETWORK=$BACKEND Enable virtual network interface with $BACKEND.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Queued, thanks!
Fam
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-08 3:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-08 2:47 [Qemu-devel] [PATCH] docker: correctly escape $BACKEND in the help output Philippe Mathieu-Daudé
2017-11-08 3:00 ` Fam Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).