From: Fam Zheng <famz@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Daniel P . Berrange" <berrange@redhat.com>,
qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] docker: correctly escape $BACKEND in the help output
Date: Wed, 8 Nov 2017 11:00:03 +0800 [thread overview]
Message-ID: <20171108030003.GB2834@lemon> (raw)
In-Reply-To: <20171108024719.8389-1-f4bug@amsat.org>
On Tue, 11/07 23:47, Philippe Mathieu-Daudé wrote:
> In Makefiles the $ must be escaped as $$ in shell uses.
>
> Since 8a2390a4f47:
>
> $ make docker
> [...]
> NETWORK=1 Enable virtual network interface with default backend.
> NETWORK=ACKEND Enable virtual network interface with ACKEND.
>
> Once escaped:
>
> $ make docker
> [...]
> NETWORK=1 Enable virtual network interface with default backend.
> NETWORK=$BACKEND Enable virtual network interface with $BACKEND.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Queued, thanks!
Fam
prev parent reply other threads:[~2017-11-08 3:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 2:47 [Qemu-devel] [PATCH] docker: correctly escape $BACKEND in the help output Philippe Mathieu-Daudé
2017-11-08 3:00 ` Fam Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108030003.GB2834@lemon \
--to=famz@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).