From: "Richard W.M. Jones" <rjones@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Alistair Francis <alistair.francis@xilinx.com>,
qemu-devel@nongnu.org, alistair23@gmail.com, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 40/45] hw/watchdog: Replace fprintf(stderr, "*\n" with error_report()
Date: Thu, 9 Nov 2017 08:47:03 +0000 [thread overview]
Message-ID: <20171109084702.GD2787@redhat.com> (raw)
In-Reply-To: <20c00ee8-6d77-e8bd-aa77-6db5db789900@amsat.org>
On Wed, Nov 08, 2017 at 08:43:45PM -0300, Philippe Mathieu-Daudé wrote:
> > @@ -126,7 +125,7 @@ void watchdog_perform_action(void)
> >
> > case WATCHDOG_ACTION_DEBUG:
> > qapi_event_send_watchdog(WATCHDOG_ACTION_DEBUG, &error_abort);
> > - fprintf(stderr, "watchdog: timer fired\n");
> > + error_report("watchdog: timer fired");
>
> I don't think this is an error and would rather use info_report() here.
>
> Richard what do you think?
Yes, this is not an error. It's an informational message.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top
next prev parent reply other threads:[~2017-11-09 8:47 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 22:56 [Qemu-devel] [PATCH v4 00/45] Remove some of the fprintf(stderr, "* Alistair Francis
2017-11-08 22:56 ` [Qemu-devel] [PATCH v4 01/45] audio: Replace AUDIO_FUNC with __func__ Alistair Francis
2017-11-08 22:56 ` [Qemu-devel] [PATCH v4 02/45] Replace all occurances of __FUNCTION__ " Alistair Francis
2017-11-08 22:56 ` [Qemu-devel] [PATCH v4 03/45] Fixes after renaming __FUNCTION__ to __func__ Alistair Francis
2017-11-08 22:56 ` [Qemu-devel] [PATCH v4 04/45] tests: Replace fprintf(stderr, "*\n" with error_report() Alistair Francis
2017-11-09 14:38 ` Eric Blake
2017-11-09 14:48 ` Philippe Mathieu-Daudé
2017-11-08 22:56 ` [Qemu-devel] [PATCH v4 05/45] hw/arm: " Alistair Francis
2017-11-08 22:56 ` [Qemu-devel] [PATCH v4 06/45] hw/block: " Alistair Francis
2017-11-09 3:02 ` Philippe Mathieu-Daudé
2017-11-08 22:56 ` [Qemu-devel] [PATCH v4 07/45] hw/bt: " Alistair Francis
2017-11-08 22:56 ` [Qemu-devel] [PATCH v4 08/45] hw/char: " Alistair Francis
2017-11-09 2:36 ` Philippe Mathieu-Daudé
2017-11-08 22:56 ` [Qemu-devel] [PATCH v4 09/45] hw/core: " Alistair Francis
2017-11-08 22:56 ` [Qemu-devel] [PATCH v4 10/45] hw/cris: " Alistair Francis
2017-11-08 22:56 ` [Qemu-devel] [PATCH v4 11/45] hw/display: " Alistair Francis
2017-11-08 22:57 ` [Qemu-devel] [PATCH v4 12/45] hw/dma: " Alistair Francis
2017-11-08 23:29 ` Philippe Mathieu-Daudé
2017-11-08 22:57 ` [Qemu-devel] [PATCH v4 13/45] hw/gpio: " Alistair Francis
2017-11-08 23:30 ` Philippe Mathieu-Daudé
2017-11-08 22:57 ` [Qemu-devel] [PATCH v4 14/45] hw/i2c: " Alistair Francis
2017-11-08 22:57 ` [Qemu-devel] [PATCH v4 16/45] hw/ide: " Alistair Francis
2017-11-08 22:57 ` [Qemu-devel] [PATCH v4 17/45] hw/input: " Alistair Francis
2017-11-08 22:57 ` [Qemu-devel] [PATCH v4 18/45] hw/intc: " Alistair Francis
2017-11-09 2:32 ` Philippe Mathieu-Daudé
2017-11-08 22:57 ` [Qemu-devel] [PATCH v4 19/45] hw/ipmi: " Alistair Francis
2017-11-08 22:57 ` [Qemu-devel] [PATCH v4 20/45] hw/isa: " Alistair Francis
2017-11-08 22:57 ` [Qemu-devel] [PATCH v4 21/45] hw/lm32: " Alistair Francis
2017-11-08 22:57 ` [Qemu-devel] [PATCH v4 22/45] hw/microblaze: " Alistair Francis
2017-11-08 22:57 ` [Qemu-devel] [PATCH v4 23/45] hw/mips: " Alistair Francis
2017-11-09 5:57 ` Hervé Poussineau
2017-11-08 22:57 ` [Qemu-devel] [PATCH v4 24/45] hw/misc: " Alistair Francis
2017-11-08 22:57 ` [Qemu-devel] [PATCH v4 25/45] hw/moxie: " Alistair Francis
2017-11-08 22:58 ` [Qemu-devel] [PATCH v4 26/45] hw/net: " Alistair Francis
2017-11-08 22:58 ` [Qemu-devel] [PATCH v4 27/45] hw/nios2: " Alistair Francis
2017-11-08 22:58 ` [Qemu-devel] [PATCH v4 28/45] hw/nvram: " Alistair Francis
2017-11-08 23:39 ` Philippe Mathieu-Daudé
2017-11-08 22:58 ` [Qemu-devel] [PATCH v4 29/45] hw/openrisc: " Alistair Francis
2017-11-09 2:30 ` Philippe Mathieu-Daudé
2017-11-08 22:58 ` [Qemu-devel] [PATCH v4 30/45] hw/pci*: " Alistair Francis
2017-11-08 22:58 ` [Qemu-devel] [PATCH v4 31/45] hw/ppc: " Alistair Francis
2017-11-09 2:29 ` Philippe Mathieu-Daudé
2017-11-08 22:58 ` [Qemu-devel] [PATCH v4 32/45] hw/s390x: " Alistair Francis
2017-11-08 22:58 ` [Qemu-devel] [PATCH v4 33/45] hw/scsi: " Alistair Francis
2017-11-08 22:58 ` [Qemu-devel] [PATCH v4 34/45] hw/sd: " Alistair Francis
2017-11-08 22:58 ` [Qemu-devel] [PATCH v4 35/45] hw/sh4: " Alistair Francis
2017-11-08 22:58 ` [Qemu-devel] [PATCH v4 36/45] hw/sparc*: " Alistair Francis
2017-11-08 22:58 ` [Qemu-devel] [PATCH v4 37/45] hw/ssi: " Alistair Francis
2017-11-08 22:58 ` [Qemu-devel] [PATCH v4 38/45] hw/timer: " Alistair Francis
2017-11-08 22:58 ` [Qemu-devel] [PATCH v4 39/45] hw/usb: " Alistair Francis
2017-11-08 22:58 ` [Qemu-devel] [PATCH v4 40/45] hw/watchdog: " Alistair Francis
2017-11-08 23:43 ` Philippe Mathieu-Daudé
2017-11-09 8:47 ` Richard W.M. Jones [this message]
2017-11-08 22:58 ` [Qemu-devel] [PATCH v4 41/45] hw/xen*: " Alistair Francis
2017-11-08 22:58 ` [Qemu-devel] [PATCH v4 42/45] util: " Alistair Francis
2017-11-08 22:58 ` [Qemu-devel] [PATCH v4 43/45] ui: " Alistair Francis
2017-11-08 22:59 ` [Qemu-devel] [PATCH v4 44/45] tcg: " Alistair Francis
2017-11-08 22:59 ` [Qemu-devel] [PATCH v4 45/45] target: Use qemu_log() instead of fprintf(stderr, ...) Alistair Francis
2017-11-09 3:08 ` [Qemu-devel] [PATCH v4 00/45] Remove some of the fprintf(stderr, "* Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109084702.GD2787@redhat.com \
--to=rjones@redhat.com \
--cc=alistair.francis@xilinx.com \
--cc=alistair23@gmail.com \
--cc=armbru@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).