From: Marcel Apfelbaum <marcel@redhat.com>
To: qemu-devel@nongnu.org
Cc: marcel@redhat.com, mst@redhat.com, thuth@redhat.com,
zuban32s@gmail.com, cohuck@redhat.com
Subject: [Qemu-devel] [PATCH V4] hw/pcie-pci-bridge: restrict to X86 and ARM
Date: Thu, 9 Nov 2017 14:58:26 +0200 [thread overview]
Message-ID: <20171109125826.120228-1-marcel@redhat.com> (raw)
The PCIE-PCI bridge is specific to "pure" PCIe systems
(on QEMU we have X86 and ARM), it does not make sense to
have it in other archs.
Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
---
V3 -> V4:
- Move the config line to pci.mak (Thomas)
V2 -> V3:
- Another tweak in subject s/if/it (Cornelia)
V1 -> V2:
Addressed Thomas and Cornelia comments:
- Conditioned the pcie-pci-bridge compilation on
the PCIe Root CONFIG_PCIE_PORT
- Tweaked subject PCI -> PCIe
Thanks,
Marcel
default-configs/pci.mak | 1 +
hw/pci-bridge/Makefile.objs | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/default-configs/pci.mak b/default-configs/pci.mak
index e514bdef42..7724b9657a 100644
--- a/default-configs/pci.mak
+++ b/default-configs/pci.mak
@@ -43,3 +43,4 @@ CONFIG_VGA_PCI=y
CONFIG_IVSHMEM_DEVICE=$(CONFIG_IVSHMEM)
CONFIG_ROCKER=y
CONFIG_VHOST_USER_SCSI=$(call land,$(CONFIG_VHOST_USER),$(CONFIG_LINUX))
+CONFIG_PCIE_PCI_BRIDGE=$(CONFIG_PCIE_PORT)
diff --git a/hw/pci-bridge/Makefile.objs b/hw/pci-bridge/Makefile.objs
index 666db37da2..9d23a7038a 100644
--- a/hw/pci-bridge/Makefile.objs
+++ b/hw/pci-bridge/Makefile.objs
@@ -1,6 +1,7 @@
-common-obj-y += pci_bridge_dev.o pcie_pci_bridge.o
+common-obj-y += pci_bridge_dev.o
common-obj-$(CONFIG_PCIE_PORT) += pcie_root_port.o gen_pcie_root_port.o
common-obj-$(CONFIG_PXB) += pci_expander_bridge.o
+common-obj-$(CONFIG_PCIE_PCI_BRIDGE) += pcie_pci_bridge.o
common-obj-$(CONFIG_XIO3130) += xio3130_upstream.o xio3130_downstream.o
common-obj-$(CONFIG_IOH3420) += ioh3420.o
common-obj-$(CONFIG_I82801B11) += i82801b11.o
--
2.13.5
next reply other threads:[~2017-11-09 12:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 12:58 Marcel Apfelbaum [this message]
2017-11-09 13:04 ` [Qemu-devel] [PATCH V4] hw/pcie-pci-bridge: restrict to X86 and ARM no-reply
2017-11-09 14:03 ` Thomas Huth
2017-11-09 14:10 ` Marcel Apfelbaum
2017-11-09 14:29 ` Philippe Mathieu-Daudé
2017-11-09 15:17 ` Marcel Apfelbaum
2017-11-09 14:08 ` Marcel Apfelbaum
2017-11-09 14:37 ` Fam Zheng
2017-11-09 15:21 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109125826.120228-1-marcel@redhat.com \
--to=marcel@redhat.com \
--cc=cohuck@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=zuban32s@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).