From: Stefan Hajnoczi <stefanha@gmail.com>
To: Zhengui Li <lizhengui@huawei.com>
Cc: kwolf@redhat.com, jcody@redhat.com, mreitz@redhat.com,
pbonzini@redhat.com, lina.lulina@huawei.com,
qemu-block@nongnu.org, subo7@huawei.com, eric.fangyi@huawei.com,
qemu-devel@nongnu.org, wangjie88@huawei.com,
sochin.jiang@huawei.com
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] block: all I/O should be completed before removing throttle timers.
Date: Thu, 9 Nov 2017 16:59:01 +0000 [thread overview]
Message-ID: <20171109165901.GC25162@stefanha-x1.localdomain> (raw)
In-Reply-To: <1508564040-120700-1-git-send-email-lizhengui@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 617 bytes --]
On Sat, Oct 21, 2017 at 01:34:00PM +0800, Zhengui Li wrote:
> From: Zhengui <lizhengui@huawei.com>
>
> In blk_remove_bs, all I/O should be completed before removing throttle
> timers. If there has inflight I/O, removing throttle timers here will
> cause the inflight I/O never return.
> This patch add bdrv_drained_begin before throttle_timers_detach_aio_context
> to let all I/O completed before removing throttle timers.
>
> Signed-off-by: Zhengui <lizhengui@huawei.com>
> ---
> block/block-backend.c | 4 ++++
> 1 file changed, 4 insertions(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-11-09 16:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-21 5:34 [Qemu-devel] [PATCH] block: all I/O should be completed before removing throttle timers Zhengui Li
2017-10-21 5:49 ` no-reply
2017-10-23 17:40 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-10-24 3:27 ` [Qemu-devel] 答复: " lizhengui
2017-11-09 16:59 ` Stefan Hajnoczi [this message]
2017-11-10 9:57 ` [Qemu-devel] " Alberto Garcia
2017-11-10 12:45 ` Alberto Garcia
2017-11-10 15:33 ` Stefan Hajnoczi
2017-11-11 2:37 ` l00284672
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109165901.GC25162@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=eric.fangyi@huawei.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=lina.lulina@huawei.com \
--cc=lizhengui@huawei.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sochin.jiang@huawei.com \
--cc=subo7@huawei.com \
--cc=wangjie88@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).