From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eD9tL-00007k-FP for qemu-devel@nongnu.org; Fri, 10 Nov 2017 09:02:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eD9tI-0007sw-Cr for qemu-devel@nongnu.org; Fri, 10 Nov 2017 09:02:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33754) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eD9tI-0007rI-7C for qemu-devel@nongnu.org; Fri, 10 Nov 2017 09:02:40 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5C146C04B31A for ; Fri, 10 Nov 2017 14:02:39 +0000 (UTC) From: Gerd Hoffmann Date: Fri, 10 Nov 2017 15:02:35 +0100 Message-Id: <20171110140236.26651-2-kraxel@redhat.com> In-Reply-To: <20171110140236.26651-1-kraxel@redhat.com> References: <20171110140236.26651-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 1/2] ui: fix dcl unregister List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann register checks for dcl->ds being NULL, to avoid registering the same dcl twice. Therefore dcl->ds must be cleared on unregister, otherwise un-registering and re-registering doesn't work. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=3D1510809 Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-Andr=C3=A9 Lureau Message-id: 20171109105154.29414-1-kraxel@redhat.com --- ui/console.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/console.c b/ui/console.c index eca854cbd5..c4c95abed7 100644 --- a/ui/console.c +++ b/ui/console.c @@ -1471,6 +1471,7 @@ void unregister_displaychangelistener(DisplayChange= Listener *dcl) dcl->con->dcls--; } QLIST_REMOVE(dcl, next); + dcl->ds =3D NULL; gui_setup_refresh(ds); } =20 --=20 2.9.3