From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v6 0/6] block: Don't compare strings in bdrv_reopen_prepare()
Date: Fri, 10 Nov 2017 18:47:42 +0100 [thread overview]
Message-ID: <20171110174742.GI5466@localhost.localdomain> (raw)
In-Reply-To: <f051da3e-9181-0e72-b9eb-4e9c2d61e971@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 776 bytes --]
Am 10.11.2017 um 18:36 hat Max Reitz geschrieben:
> On 2017-11-10 10:16, Markus Armbruster wrote:
> > Max Reitz <mreitz@redhat.com> writes:
> >
> >> bdrv_reopen_prepare() assumes that all BDS options are strings, which is
> >> not necessarily correct. This series introduces a new qobject_is_equal()
> >> function which can be used to test whether any options have changed,
> >> independently of their type.
> >
> > Series looks ready to me. It touches QAPI to achieve its purpose in the
> > block layer; I'd be fine with merging it via a block tree.
>
> Thanks! So now it's my problem to figure out whether this is 2.11
> material...? :-)
The test case in patch 5 segfaults without the series. Why would it not
be a bug fix (= 2.11 material)?
Kevin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-11-10 17:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 15:25 [Qemu-devel] [PATCH v6 0/6] block: Don't compare strings in bdrv_reopen_prepare() Max Reitz
2017-10-04 15:25 ` [Qemu-devel] [PATCH v6 1/6] qapi/qnull: Add own header Max Reitz
2017-10-04 15:25 ` [Qemu-devel] [PATCH v6 2/6] qapi/qlist: Add qlist_append_null() macro Max Reitz
2017-10-04 21:06 ` Eric Blake
2017-10-05 10:21 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2017-10-04 15:25 ` [Qemu-devel] [PATCH v6 3/6] qapi: Add qobject_is_equal() Max Reitz
2017-10-04 15:25 ` [Qemu-devel] [PATCH v6 4/6] block: qobject_is_equal() in bdrv_reopen_prepare() Max Reitz
2017-10-04 15:25 ` [Qemu-devel] [PATCH v6 5/6] iotests: Add test for non-string option reopening Max Reitz
2017-10-04 15:25 ` [Qemu-devel] [PATCH v6 6/6] tests: Add check-qobject for equality tests Max Reitz
2017-10-04 21:18 ` Eric Blake
2017-11-10 9:15 ` Markus Armbruster
2017-11-10 9:16 ` [Qemu-devel] [PATCH v6 0/6] block: Don't compare strings in bdrv_reopen_prepare() Markus Armbruster
2017-11-10 17:36 ` Max Reitz
2017-11-10 17:47 ` Kevin Wolf [this message]
2017-11-10 18:06 ` Max Reitz
2017-11-14 15:48 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171110174742.GI5466@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).