From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, Alberto Garcia <berto@igalia.com>,
John Snow <jsnow@redhat.com>
Subject: [Qemu-devel] [PATCH for-2.11 0/5] qcow2: Fixes for corrupted images
Date: Fri, 10 Nov 2017 21:31:06 +0100 [thread overview]
Message-ID: <20171110203111.7666-1-mreitz@redhat.com> (raw)
This series contains fixes for another batch of qcow2-related crashes
reported on Launchpad by Nageswara (the first batch was
http://lists.nongnu.org/archive/html/qemu-block/2017-11/msg00082.html by
Berto).
Patch 4 fixes an out-of-bounds array access in memory which is not
really a security issue for multiple reasons (really, at most you can
read eight bytes from somewhere with an extremely high chance of
crashing qemu and requiring the user to invoke a block_resize shrinking
the qcow2 image (and also reset some bit in the image from 1 to 0, but
only if the overlap checks don't catch you)), but most importantly that
code hasn't been in 2.10, so we're fine.
Max Reitz (5):
qcow2: check_errors are fatal
qcow2: Unaligned zero cluster in handle_alloc()
block: Guard against NULL bs->drv
qcow2: Add bounds check to get_refblock_offset()
qcow2: Refuse to get unaligned offsets from cache
block/qcow2.h | 6 ---
block.c | 19 ++++++-
block/io.c | 36 +++++++++++++
block/qapi.c | 8 ++-
block/qcow2-cache.c | 21 ++++++++
block/qcow2-cluster.c | 13 ++++-
block/qcow2-refcount.c | 26 +++++++++-
block/qcow2.c | 5 +-
block/replication.c | 15 ++++++
block/vvfat.c | 2 +-
tests/qemu-iotests/060 | 125 +++++++++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/060.out | 115 +++++++++++++++++++++++++++++++++++++++++
12 files changed, 379 insertions(+), 12 deletions(-)
--
2.13.6
next reply other threads:[~2017-11-10 20:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 20:31 Max Reitz [this message]
2017-11-10 20:31 ` [Qemu-devel] [PATCH for-2.11 1/5] qcow2: check_errors are fatal Max Reitz
2017-11-10 20:55 ` Eric Blake
2017-11-10 20:31 ` [Qemu-devel] [PATCH for-2.11 2/5] qcow2: Unaligned zero cluster in handle_alloc() Max Reitz
2017-11-10 20:58 ` Eric Blake
2017-11-14 14:55 ` Alberto Garcia
2017-11-10 20:31 ` [Qemu-devel] [PATCH for-2.11 3/5] block: Guard against NULL bs->drv Max Reitz
2017-11-10 21:46 ` Eric Blake
2017-11-14 15:36 ` Max Reitz
2017-11-10 20:31 ` [Qemu-devel] [PATCH for-2.11 4/5] qcow2: Add bounds check to get_refblock_offset() Max Reitz
2017-11-10 21:49 ` Eric Blake
2017-11-14 15:02 ` Alberto Garcia
2017-11-14 15:27 ` Max Reitz
2017-11-14 15:38 ` Alberto Garcia
2017-11-14 15:40 ` Max Reitz
2017-11-10 20:31 ` [Qemu-devel] [PATCH for-2.11 5/5] qcow2: Refuse to get unaligned offsets from cache Max Reitz
2017-11-10 21:54 ` Eric Blake
2017-11-10 22:00 ` Max Reitz
2017-11-10 22:15 ` Eric Blake
2017-11-10 22:16 ` Max Reitz
2017-11-14 15:06 ` Alberto Garcia
2017-11-14 15:09 ` Max Reitz
2017-11-14 15:31 ` Alberto Garcia
2017-11-10 20:41 ` [Qemu-devel] [PATCH for-2.11 0/5] qcow2: Fixes for corrupted images Max Reitz
2017-11-15 20:25 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171110203111.7666-1-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=berto@igalia.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).