From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Kevin Wolf <kwolf@redhat.com>
Subject: [Qemu-devel] [PATCH for-2.12 0/3] block: Handle null backing link
Date: Fri, 10 Nov 2017 23:13:26 +0100 [thread overview]
Message-ID: <20171110221329.24176-1-mreitz@redhat.com> (raw)
Currently, we try to rewrite every occurrence of "backing": null into
"backing": "" in qmp_blockdev_add(). However, that breaks using the
same "backing": null construction in json:{} file names (which do not go
through qmp_blockdev_add()). Currently, these then just behave as if
the option has not been specified.
Since there is actually only one place where we evaluate the @backing
option to find out whether not to use a backing file, we can instead
just check for null there. It doesn't matter that this changes the
runtime state of the option from "" to null, because nobody really does
anything with that runtime state anyway (except put it into qemu again,
but qemu doesn't care whether it's "" or null).
And in the future, it's much better if we get it to be null in that
runtime state sooner than later -- see patch 3. :-)
Max Reitz (3):
qapi: Add qdict_is_null()
block: Handle null backing link
block: Deprecate "backing": ""
qapi/block-core.json | 4 ++--
include/qapi/qmp/qdict.h | 1 +
block.c | 6 +++++-
blockdev.c | 14 --------------
qobject/qdict.c | 10 ++++++++++
qemu-doc.texi | 7 +++++++
qemu-options.hx | 4 ++--
tests/qemu-iotests/089 | 20 ++++++++++++++++++++
tests/qemu-iotests/089.out | 8 ++++++++
9 files changed, 55 insertions(+), 19 deletions(-)
--
2.13.6
next reply other threads:[~2017-11-10 22:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 22:13 Max Reitz [this message]
2017-11-10 22:13 ` [Qemu-devel] [PATCH for-2.12 1/3] qapi: Add qdict_is_null() Max Reitz
2017-11-10 22:19 ` Eric Blake
2017-11-14 14:07 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2017-11-14 14:15 ` Max Reitz
2017-11-14 14:57 ` [Qemu-devel] " Markus Armbruster
2017-11-14 14:59 ` Max Reitz
2017-11-15 6:51 ` Markus Armbruster
2017-11-10 22:13 ` [Qemu-devel] [PATCH for-2.12 2/3] block: Handle null backing link Max Reitz
2017-11-10 22:22 ` Eric Blake
2017-11-10 22:26 ` Max Reitz
2017-11-14 14:06 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2017-11-14 15:17 ` [Qemu-devel] " Markus Armbruster
2017-11-14 15:19 ` Max Reitz
2017-11-10 22:13 ` [Qemu-devel] [PATCH for-2.12 3/3] block: Deprecate "backing": "" Max Reitz
2017-11-10 22:21 ` Eric Blake
2017-11-13 10:25 ` Daniel P. Berrange
2017-11-14 15:19 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171110221329.24176-1-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).