[Qemu-devel] Command-line option to change ungrab key(s)

[Qemu-devel] Command-line option to change ungrab key(s)

[Programmingkid]

Would you accept a patch that allows the user to change the mouse ungrab key(s) in QEMU?

It would look something like this: 

-ungrab <key> 

or 

-ungrab <key>,<key>,...

If the user wanted the F19 key to be the ungrab key, this is what would be sent to QEMU:

-ungrab F19

If the user wanted F16 and F17 held down to ungrab the mouse, this is what would be sent to QEMU:

-ungrab F16,F17


Would this feature be something you would consider adding to QEMU?

Re: [Qemu-devel] Command-line option to change ungrab key(s)

[Peter Maydell]

On 13 November 2017 at 14:29, Programmingkid <programmingkidx@gmail.com> wrote:
> Would you accept a patch that allows the user to change the mouse ungrab key(s) in QEMU?
>
> It would look something like this:
>
> -ungrab <key>
>
> or
>
> -ungrab <key>,<key>,...
>
> If the user wanted the F19 key to be the ungrab key, this is what would be sent to QEMU:
>
> -ungrab F19
>
> If the user wanted F16 and F17 held down to ungrab the mouse, this is what would be sent to QEMU:
>
> -ungrab F16,F17
>
>
> Would this feature be something you would consider adding to QEMU?

Gerd is the graphics/UI overall maintainer, that kind of thing would be
his decision.

thanks
-- PMM

Re: [Qemu-devel] Command-line option to change ungrab key(s)

[Daniel P. Berrange]

On Mon, Nov 13, 2017 at 09:29:25AM -0500, Programmingkid wrote:
> Would you accept a patch that allows the user to change the mouse ungrab key(s) in QEMU?
> 
> It would look something like this: 
> 
> -ungrab <key> 
> 
> or 
> 
> -ungrab <key>,<key>,...
> 
> If the user wanted the F19 key to be the ungrab key, this is what would be sent to QEMU:
> 
> -ungrab F19
> 
> If the user wanted F16 and F17 held down to ungrab the mouse, this is what would be sent to QEMU:
> 
> -ungrab F16,F17
> 
> 
> Would this feature be something you would consider adding to QEMU?

As context, virt-manager allows customization for the ungrab sequence, and
so do spice-gtk/gtk-vnc at the API level. So conceptually I think it is
reasonable for any UI console that is intended as more than just a toy.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [Qemu-devel] Command-line option to change ungrab key(s)

[Marc-André Lureau]

Hi

On Mon, Nov 13, 2017 at 3:50 PM, Daniel P. Berrange <berrange@redhat.com> wrote:
> On Mon, Nov 13, 2017 at 09:29:25AM -0500, Programmingkid wrote:
>> Would you accept a patch that allows the user to change the mouse ungrab key(s) in QEMU?
>>
>> It would look something like this:
>>
>> -ungrab <key>
>>
>> or
>>
>> -ungrab <key>,<key>,...
>>
>> If the user wanted the F19 key to be the ungrab key, this is what would be sent to QEMU:
>>
>> -ungrab F19
>>
>> If the user wanted F16 and F17 held down to ungrab the mouse, this is what would be sent to QEMU:
>>
>> -ungrab F16,F17
>>
>>
>> Would this feature be something you would consider adding to QEMU?
>
> As context, virt-manager allows customization for the ungrab sequence, and
> so do spice-gtk/gtk-vnc at the API level. So conceptually I think it is
> reasonable for any UI console that is intended as more than just a toy.

Would it make sense to share the virt-viewer/remote-viewer --hotkeys
option format ? (see man remote-viewer / virt-viewer)



-- 
Marc-André Lureau

Re: [Qemu-devel] Command-line option to change ungrab key(s)

[Programmingkid]

> On Nov 13, 2017, at 10:20 AM, Marc-André Lureau <marcandre.lureau@gmail.com> wrote:
> 
> Hi
> 
> On Mon, Nov 13, 2017 at 3:50 PM, Daniel P. Berrange <berrange@redhat.com> wrote:
>> On Mon, Nov 13, 2017 at 09:29:25AM -0500, Programmingkid wrote:
>>> Would you accept a patch that allows the user to change the mouse ungrab key(s) in QEMU?
>>> 
>>> It would look something like this:
>>> 
>>> -ungrab <key>
>>> 
>>> or
>>> 
>>> -ungrab <key>,<key>,...
>>> 
>>> If the user wanted the F19 key to be the ungrab key, this is what would be sent to QEMU:
>>> 
>>> -ungrab F19
>>> 
>>> If the user wanted F16 and F17 held down to ungrab the mouse, this is what would be sent to QEMU:
>>> 
>>> -ungrab F16,F17
>>> 
>>> 
>>> Would this feature be something you would consider adding to QEMU?
>> 
>> As context, virt-manager allows customization for the ungrab sequence, and
>> so do spice-gtk/gtk-vnc at the API level. So conceptually I think it is
>> reasonable for any UI console that is intended as more than just a toy.
> 
> Would it make sense to share the virt-viewer/remote-viewer --hotkeys
> option format ? (see man remote-viewer / virt-viewer)

I think you are referring to information found on this page: https://www.mankier.com/1/remote-viewer

The command-line option for changing hotkey actions would be:
--hotkeys=<action1>=<key1>[+<key2>][,<action2>=<key3>[+<key4>]]

So this means changing the mouse ungrab would look something like this:

--hotkeys=release-cursor=F19 (or some other key)

Gerd what you think of this idea?

Re: [Qemu-devel] Command-line option to change ungrab key(s)

[Gerd Hoffmann]

  Hi,

> >>> Would this feature be something you would consider adding to QEMU?
> >> 
> >> As context, virt-manager allows customization for the ungrab sequence, and
> >> so do spice-gtk/gtk-vnc at the API level. So conceptually I think it is
> >> reasonable for any UI console that is intended as more than just a toy.
> > 
> > Would it make sense to share the virt-viewer/remote-viewer --hotkeys
> > option format ? (see man remote-viewer / virt-viewer)
> 
> I think you are referring to information found on this page: https://www.mankier.com/1/remote-viewer
> 
> The command-line option for changing hotkey actions would be:
> --hotkeys=<action1>=<key1>[+<key2>][,<action2>=<key3>[+<key4>]]
> 
> So this means changing the mouse ungrab would look something like this:
> 
> --hotkeys=release-cursor=F19 (or some other key)
> 
> Gerd what you think of this idea?

Certainly not this way.  The display configuration we have right now is
pretty messy already.  I want clean this up (draft patch series at
https://www.kraxel.org/cgit/qemu/log/?h=lupin/display-cmdline), and this
should be done before adding new stuff.

Also when making this configurable it should be consistent across all
user interfaces we have, which surely is a non-trivial amount of work.

cheers,
  Gerd

Re: [Qemu-devel] Command-line option to change ungrab key(s)

[Programmingkid]

> On Nov 14, 2017, at 2:21 AM, Gerd Hoffmann <kraxel@redhat.com> wrote:
> 
>  Hi,
> 
>>>>> Would this feature be something you would consider adding to QEMU?
>>>> 
>>>> As context, virt-manager allows customization for the ungrab sequence, and
>>>> so do spice-gtk/gtk-vnc at the API level. So conceptually I think it is
>>>> reasonable for any UI console that is intended as more than just a toy.
>>> 
>>> Would it make sense to share the virt-viewer/remote-viewer --hotkeys
>>> option format ? (see man remote-viewer / virt-viewer)
>> 
>> I think you are referring to information found on this page: https://www.mankier.com/1/remote-viewer
>> 
>> The command-line option for changing hotkey actions would be:
>> --hotkeys=<action1>=<key1>[+<key2>][,<action2>=<key3>[+<key4>]]
>> 
>> So this means changing the mouse ungrab would look something like this:
>> 
>> --hotkeys=release-cursor=F19 (or some other key)
>> 
>> Gerd what you think of this idea?
> 
> Certainly not this way.

Did you have an idea on how something like this should look like? This feature would only change the old mouse ungrab keys to a user-specified one. So the basic algorithm would be change the text that displays at the top of the QEMU window to say (Press <user specified key(s)> to release mouse. Then tell the code that looks for the ungrab keys which keys to look out for.

>  The display configuration we have right now is
> pretty messy already.  I want clean this up (draft patch series at
> https://www.kraxel.org/cgit/qemu/log/?h=lupin/display-cmdline), and this
> should be done before adding new stuff.

My original idea was to make a patch that would only change the cocoa.m file. I'm thinking you want this code to be elsewhere. Somewhere where other UI code like GTK would be able to use. Is that what you prefer?

> Also when making this configurable it should be consistent across all
> user interfaces we have, which surely is a non-trivial amount of work.

I know Cocoa but my lack of GTK experience would not permit me to make a patch for that UI code. When you are done with your display configuration work, would there even be a need to patch the Cocoa/GTK code? I'm under the impression you are trying to consolidate some of the UI code under one file. This does sound like a logic move to make. It would help to keep things consistent across different hosts.

Re: [Qemu-devel] Command-line option to change ungrab key(s)

[Gerd Hoffmann]

  Hi,

> > Certainly not this way.
> 
> Did you have an idea on how something like this should look like? This
> feature would only change the old mouse ungrab keys to a
> user-specified one. So the basic algorithm would be change the text
> that displays at the top of the QEMU window to say (Press <user
> specified key(s)> to release mouse.

That is the easy part ;)

> Then tell the code that looks for
> the ungrab keys which keys to look out for.

Here it becomes more difficuilt.

> >  The display configuration we have right now is pretty messy
> >  already.  I want clean this up (draft patch series at
> >  https://www.kraxel.org/cgit/qemu/log/?h=lupin/display-cmdline), and
> >  this should be done before adding new stuff.
> 
> My original idea was to make a patch that would only change the
> cocoa.m file. I'm thinking you want this code to be elsewhere.
> Somewhere where other UI code like GTK would be able to use. Is that
> what you prefer?

Well, at least the command line parsing part should be in common code,
yes.  Detecting and handling the hotkeys will most likely stay in
UI-specific code.

> > Also when making this configurable it should be consistent across
> > all user interfaces we have, which surely is a non-trivial amount of
> > work.
> 
> I know Cocoa but my lack of GTK experience would not permit me to make
> a patch for that UI code. When you are done with your display
> configuration work, would there even be a need to patch the Cocoa/GTK
> code? I'm under the impression you are trying to consolidate some of
> the UI code under one file.

No.  But standardize the interface between UIs and qemu, which will not
only standardize the configuration, but should also make it easier to
build the UIs as modules.

cheers,
  Gerd