From: Amador Pahim <apahim@redhat.com>
To: qemu-devel@nongnu.org
Cc: famz@redhat.com, crosa@redhat.com, ehabkost@redhat.com,
Amador Pahim <apahim@redhat.com>
Subject: [Qemu-devel] [PATCH v9 7/8] qemu.py: launch vm only if it's not running
Date: Mon, 13 Nov 2017 22:39:44 +0100 [thread overview]
Message-ID: <20171113213945.20049-8-apahim@redhat.com> (raw)
In-Reply-To: <20171113213945.20049-1-apahim@redhat.com>
If we allow launching VM again we will loose track of the first launched
VM.
Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Amador Pahim <apahim@redhat.com>
---
scripts/qemu.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/scripts/qemu.py b/scripts/qemu.py
index ed9fed58ed..7303952328 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -197,6 +197,9 @@ class QEMUMachine(object):
Launch the VM and make sure we cleanup and expose the
command line/output in case of exception
"""
+ if self.is_running():
+ raise QEMUMachineError('VM already running')
+
self._iolog = None
self._qemu_full_args = None
try:
--
2.13.6
next prev parent reply other threads:[~2017-11-13 21:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 21:39 [Qemu-devel] [PATCH v9 0/8] scripts/qemu.py fixes and cleanups Amador Pahim
2017-11-13 21:39 ` [Qemu-devel] [PATCH v9 1/8] qemu.py: remove unused import Amador Pahim
2017-11-13 21:39 ` [Qemu-devel] [PATCH v9 2/8] qemu.py: better control of created files Amador Pahim
2017-11-14 0:08 ` Murilo Opsfelder Araújo
2017-11-14 7:55 ` Amador Pahim
2017-11-13 21:39 ` [Qemu-devel] [PATCH v9 3/8] qemu.py: refactor launch() Amador Pahim
2017-11-13 21:39 ` [Qemu-devel] [PATCH v9 4/8] qemu.py: always cleanup on shutdown() Amador Pahim
2017-11-13 21:39 ` [Qemu-devel] [PATCH v9 5/8] qemu.py: use poll() instead of 'returncode' Amador Pahim
2017-11-13 21:39 ` [Qemu-devel] [PATCH v9 6/8] qemu.py: cleanup redundant calls in launch() Amador Pahim
2017-11-13 21:39 ` Amador Pahim [this message]
2017-11-13 21:39 ` [Qemu-devel] [PATCH v9 8/8] qemu.py: don't launch again before shutdown() Amador Pahim
2017-11-13 22:09 ` [Qemu-devel] [PATCH v9 0/8] scripts/qemu.py fixes and cleanups no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171113213945.20049-8-apahim@redhat.com \
--to=apahim@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).