qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Amador Pahim <apahim@redhat.com>
To: qemu-devel@nongnu.org
Cc: famz@redhat.com, crosa@redhat.com, ehabkost@redhat.com,
	Amador Pahim <apahim@redhat.com>
Subject: [Qemu-devel] [PATCH v10 6/8] qemu.py: cleanup redundant calls in launch()
Date: Mon, 13 Nov 2017 23:23:56 +0100	[thread overview]
Message-ID: <20171113222358.30967-7-apahim@redhat.com> (raw)
In-Reply-To: <20171113222358.30967-1-apahim@redhat.com>

Now that shutdown() is guaranteed to always execute self._load_io_log()
and self._post_shutdown(), their calls in 'except' became redundant and
we can safely replace it by a call to shutdown().

Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Amador Pahim <apahim@redhat.com>
---
 scripts/qemu.py | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/scripts/qemu.py b/scripts/qemu.py
index 7224f88526..df2fca9e71 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -212,11 +212,7 @@ class QEMUMachine(object):
         try:
             self._launch()
         except:
-            if self.is_running():
-                self._popen.kill()
-                self._popen.wait()
-            self._load_io_log()
-            self._post_shutdown()
+            self.shutdown()
 
             LOG.debug('Error launching VM')
             if self._qemu_full_args:
-- 
2.13.6

  parent reply	other threads:[~2017-11-13 22:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-13 22:23 [Qemu-devel] [PATCH v10 0/8] scripts/qemu.py fixes and cleanups Amador Pahim
2017-11-13 22:23 ` [Qemu-devel] [PATCH v10 1/8] qemu.py: remove unused import Amador Pahim
2017-11-13 22:23 ` [Qemu-devel] [PATCH v10 2/8] qemu.py: better control of created files Amador Pahim
2017-11-13 23:03   ` Amador Pahim
2017-11-13 22:23 ` [Qemu-devel] [PATCH v10 3/8] qemu.py: refactor launch() Amador Pahim
2017-11-13 22:23 ` [Qemu-devel] [PATCH v10 4/8] qemu.py: always cleanup on shutdown() Amador Pahim
2017-11-13 22:23 ` [Qemu-devel] [PATCH v10 5/8] qemu.py: use poll() instead of 'returncode' Amador Pahim
2017-11-13 22:23 ` Amador Pahim [this message]
2017-11-13 22:23 ` [Qemu-devel] [PATCH v10 7/8] qemu.py: launch vm only if it's not running Amador Pahim
2017-11-13 22:23 ` [Qemu-devel] [PATCH v10 8/8] qemu.py: don't launch again before shutdown() Amador Pahim
2017-11-13 22:52 ` [Qemu-devel] [PATCH v10 0/8] scripts/qemu.py fixes and cleanups no-reply
2017-11-14  7:33 ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171113222358.30967-7-apahim@redhat.com \
    --to=apahim@redhat.com \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=famz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).