From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org,
boost.lists@gmail.com, quintela@redhat.com, jasowang@redhat.com,
mst@redhat.com, zuban32s@gmail.com,
maria.klimushenkova@ispras.ru, dovgaluk@ispras.ru,
kraxel@redhat.com, pavel.dovgaluk@ispras.ru, pbonzini@redhat.com,
alex.bennee@linaro.org
Subject: [Qemu-devel] [RFC PATCH v2 05/26] replay: fixed replay_enable_events
Date: Tue, 14 Nov 2017 11:17:00 +0300 [thread overview]
Message-ID: <20171114081700.27640.34609.stgit@pasha-VirtualBox> (raw)
In-Reply-To: <20171114081630.27640.53933.stgit@pasha-VirtualBox>
This patch fixes assignment to internal events_enabled variable.
Now it is set only in record/replay mode. This affects the behavior
of the external functions that check this flag.
Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
---
replay/replay-events.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/replay/replay-events.c b/replay/replay-events.c
index 768b505..e858254 100644
--- a/replay/replay-events.c
+++ b/replay/replay-events.c
@@ -67,7 +67,9 @@ static void replay_run_event(Event *event)
void replay_enable_events(void)
{
- events_enabled = true;
+ if (replay_mode != REPLAY_MODE_NONE) {
+ events_enabled = true;
+ }
}
bool replay_has_events(void)
@@ -141,7 +143,7 @@ void replay_add_event(ReplayAsyncEventKind event_kind,
void replay_bh_schedule_event(QEMUBH *bh)
{
- if (replay_mode != REPLAY_MODE_NONE && events_enabled) {
+ if (events_enabled) {
uint64_t id = replay_get_current_step();
replay_add_event(REPLAY_ASYNC_EVENT_BH, bh, NULL, id);
} else {
@@ -161,7 +163,7 @@ void replay_add_input_sync_event(void)
void replay_block_event(QEMUBH *bh, uint64_t id)
{
- if (replay_mode != REPLAY_MODE_NONE && events_enabled) {
+ if (events_enabled) {
replay_add_event(REPLAY_ASYNC_EVENT_BLOCK, bh, NULL, id);
} else {
qemu_bh_schedule(bh);
next prev parent reply other threads:[~2017-11-14 8:16 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 8:16 [Qemu-devel] [RFC PATCH v2 00/26] replay additions Pavel Dovgalyuk
2017-11-14 8:16 ` [Qemu-devel] [RFC PATCH v2 01/26] block: implement bdrv_snapshot_goto for blkreplay Pavel Dovgalyuk
2017-11-14 8:16 ` [Qemu-devel] [RFC PATCH v2 02/26] blkreplay: create temporary overlay for underlaying devices Pavel Dovgalyuk
2017-11-14 8:16 ` [Qemu-devel] [RFC PATCH v2 03/26] replay: disable default snapshot for record/replay Pavel Dovgalyuk
2017-11-14 8:16 ` [Qemu-devel] [RFC PATCH v2 04/26] replay: fix processing async events Pavel Dovgalyuk
2017-11-14 13:34 ` Paolo Bonzini
2017-11-14 8:17 ` Pavel Dovgalyuk [this message]
2017-11-14 13:34 ` [Qemu-devel] [RFC PATCH v2 05/26] replay: fixed replay_enable_events Paolo Bonzini
2017-11-14 8:17 ` [Qemu-devel] [RFC PATCH v2 06/26] replay: fix save/load vm for non-empty queue Pavel Dovgalyuk
2017-11-14 8:17 ` [Qemu-devel] [RFC PATCH v2 07/26] replay: added replay log format description Pavel Dovgalyuk
2017-11-14 13:34 ` Paolo Bonzini
2017-11-14 8:17 ` [Qemu-devel] [RFC PATCH v2 08/26] replay: make safe vmstop at record/replay Pavel Dovgalyuk
2017-11-14 8:17 ` [Qemu-devel] [RFC PATCH v2 09/26] replay: save prior value of the host clock Pavel Dovgalyuk
2017-11-14 13:35 ` Paolo Bonzini
2017-11-14 8:17 ` [Qemu-devel] [RFC PATCH v2 10/26] icount: fixed saving/restoring of icount warp timers Pavel Dovgalyuk
2017-11-14 13:35 ` Paolo Bonzini
2017-11-14 8:17 ` [Qemu-devel] [RFC PATCH v2 11/26] target/arm/arm-powertctl: drop BQL assertions Pavel Dovgalyuk
2017-11-14 8:17 ` [Qemu-devel] [RFC PATCH v2 12/26] cpus: push BQL lock to qemu_*_wait_io_event Pavel Dovgalyuk
2017-11-14 8:17 ` [Qemu-devel] [RFC PATCH v2 13/26] cpus: only take BQL for sleeping threads Pavel Dovgalyuk
2017-11-14 8:17 ` [Qemu-devel] [RFC PATCH v2 14/26] replay/replay.c: bump REPLAY_VERSION again Pavel Dovgalyuk
2017-11-14 13:35 ` Paolo Bonzini
2017-11-14 8:17 ` [Qemu-devel] [RFC PATCH v2 15/26] replay/replay-internal.c: track holding of replay_lock Pavel Dovgalyuk
2017-11-14 8:18 ` [Qemu-devel] [RFC PATCH v2 16/26] replay: make locking visible outside replay code Pavel Dovgalyuk
2017-11-14 8:18 ` [Qemu-devel] [RFC PATCH v2 17/26] replay: push replay_mutex_lock up the call tree Pavel Dovgalyuk
2017-11-14 8:18 ` [Qemu-devel] [RFC PATCH v2 18/26] cpu-exec: don't overwrite exception_index Pavel Dovgalyuk
2017-11-14 13:37 ` Paolo Bonzini
2017-11-14 8:18 ` [Qemu-devel] [RFC PATCH v2 19/26] cpu-exec: reset exit flag before calling cpu_exec_nocache Pavel Dovgalyuk
2017-11-14 13:38 ` Paolo Bonzini
2017-11-14 8:18 ` [Qemu-devel] [RFC PATCH v2 20/26] replay: don't destroy mutex at exit Pavel Dovgalyuk
2017-11-14 13:36 ` Paolo Bonzini
2017-11-14 8:18 ` [Qemu-devel] [RFC PATCH v2 21/26] replay: check return values of fwrite Pavel Dovgalyuk
2017-11-14 13:37 ` Paolo Bonzini
2017-11-14 8:18 ` [Qemu-devel] [RFC PATCH v2 22/26] scripts/qemu-gdb: add simple tcg lock status helper Pavel Dovgalyuk
2017-11-14 8:18 ` [Qemu-devel] [RFC PATCH v2 23/26] util/qemu-thread-*: add qemu_lock, locked and unlock trace events Pavel Dovgalyuk
2017-11-14 8:18 ` [Qemu-devel] [RFC PATCH v2 24/26] scripts/analyse-locks-simpletrace.py: script to analyse lock times Pavel Dovgalyuk
2017-11-14 8:18 ` [Qemu-devel] [RFC PATCH v2 25/26] scripts/replay-dump.py: replay log dumper Pavel Dovgalyuk
2017-11-14 8:18 ` [Qemu-devel] [RFC PATCH v2 26/26] scripts/qemu-gdb/timers.py: new helper to dump timer state Pavel Dovgalyuk
2017-11-14 8:58 ` [Qemu-devel] [RFC PATCH v2 00/26] replay additions no-reply
2017-11-14 9:03 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171114081700.27640.34609.stgit@pasha-VirtualBox \
--to=pavel.dovgaluk@ispras.ru \
--cc=alex.bennee@linaro.org \
--cc=boost.lists@gmail.com \
--cc=dovgaluk@ispras.ru \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=maria.klimushenkova@ispras.ru \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zuban32s@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).