From: BALATON Zoltan <balaton@eik.bme.hu>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Richard Henderson <rth@twiddle.net>, Fam Zheng <famz@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PATCH] exec: Skip mru section if it's a partial page and not resolving subpage
Date: Tue, 14 Nov 2017 23:42:35 +0100 [thread overview]
Message-ID: <20171114225941.072707456B5@zero.eik.bme.hu> (raw)
This fixes a crash caused by picking the wrong memory region in
address_space_lookup_region seen with client code accessing a device
model that uses alias memory regions.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
exec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/exec.c b/exec.c
index 97a24a8..e5f2b9a 100644
--- a/exec.c
+++ b/exec.c
@@ -413,6 +413,7 @@ static MemoryRegionSection *address_space_lookup_region(AddressSpaceDispatch *d,
bool update;
if (section && section != &d->map.sections[PHYS_SECTION_UNASSIGNED] &&
+ (resolve_subpage || !section->offset_within_region) &&
section_covers_addr(section, addr)) {
update = false;
} else {
--
2.7.6
next reply other threads:[~2017-11-14 22:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 22:42 BALATON Zoltan [this message]
2017-11-15 13:56 ` [Qemu-devel] [PATCH] exec: Skip mru section if it's a partial page and not resolving subpage Paolo Bonzini
2017-11-15 19:00 ` BALATON Zoltan
2017-11-15 21:14 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171114225941.072707456B5@zero.eik.bme.hu \
--to=balaton@eik.bme.hu \
--cc=crosthwaite.peter@gmail.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).