From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eEvH3-0007jv-BA for qemu-devel@nongnu.org; Wed, 15 Nov 2017 05:50:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eEvGy-0005E6-5Y for qemu-devel@nongnu.org; Wed, 15 Nov 2017 05:50:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46220) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eEvGx-0005DU-UC for qemu-devel@nongnu.org; Wed, 15 Nov 2017 05:50:24 -0500 Date: Wed, 15 Nov 2017 10:50:15 +0000 From: Stefan Hajnoczi Message-ID: <20171115105015.GE8130@stefanha-x1.localdomain> References: <20171106094643.14881-1-peterx@redhat.com> <20171106094643.14881-19-peterx@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="19uQFt6ulqmgNgg1" Content-Disposition: inline In-Reply-To: <20171106094643.14881-19-peterx@redhat.com> Subject: Re: [Qemu-devel] [RFC v3 18/27] qmp: add new event "request-dropped" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , "Daniel P . Berrange" , Paolo Bonzini , Fam Zheng , Jiri Denemark , Juan Quintela , mdroth@linux.vnet.ibm.com, Eric Blake , Laurent Vivier , marcandre.lureau@redhat.com, Markus Armbruster , "Dr . David Alan Gilbert" --19uQFt6ulqmgNgg1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 06, 2017 at 05:46:34PM +0800, Peter Xu wrote: > diff --git a/qapi-schema.json b/qapi-schema.json > index 531fd4c0db..650714da06 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -3222,3 +3222,38 @@ > # Since: 2.11 > ## > { 'command': 'watchdog-set-action', 'data' : {'action': 'WatchdogAction'} } > + > +## > +# @RequestDropReason: > +# > +# Reasons that caused one request to be dropped. Please use "command" consistently. QMP does not call it not "request". > +# > +# @queue-full: the queue of request is full. > +# > +# Since: 2.12 > +## > +{ 'enum': 'RequestDropReason', > + 'data': ['queue-full' ] } > + > +## > +# @REQUEST_DROPPED: > +# > +# Emitted when one QMP request is dropped due to some reason. Please add: REQUEST_DROPPED is only emitted when the oob capability is enabled. Rationale: old clients don't know about this event so they cannot be expected to handle it! > +# > +# @id: If the original request contains an string-typed "id" field, > +# it'll be put into this field. Otherwise it'll be an empty > +# string. Please change: @id: The dropped command's string-typed "id" field. Sending commands without the id field is likely to cause confusion since there are cases where the client is unable to determine which command was meant. Since client code needs to be updated to enable the oob capability anyway, we might as well require that clients always include the id field with every command when the oob capability is enabled. Please mention this requirement where the oob capability is documented. --19uQFt6ulqmgNgg1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJaDBvmAAoJEJykq7OBq3PIZUYH/3OQX5a8M0lK48R0eMj4VNNO iGdMVkhGY6MA9LnnrwGL9BHr9sr6fFZMmeXSILuNC6T+tV0v33hpS39BLZn6BMzo U/XSXtXPQPp8x5GGMSbP8E3t40/atuQ3ks4s6P0N8mjfQoMhpp1EJsgifMkQSmNA p2f1RiB5KUDRpK2+FGAaS4KHI3UsDiNL/HjSWzkKA6V9KseB91Q+NF4lr1sugL0y HbWA3y6kakgISnaL41onPHhNqOsBAO12eZndanRrzu/43xjfaTly2EhjxJgipen3 heEFwDGJEL3igNFPIU8v8gu51ZlQy7SEmrGFU+tDfXnD2z35W2C2jIXnWXDU+GU= =gSbQ -----END PGP SIGNATURE----- --19uQFt6ulqmgNgg1--