Re: [Qemu-devel] [PATCH v6] NUMA: Enable adding NUMA node implicitly

[Igor Mammedov <imammedo@redhat.com>]

On Wed, 15 Nov 2017 09:29:22 +0800
Dou Liyang <douly.fnst@cn.fujitsu.com> wrote:

> Hi Igor,
> 
> [...]
> >> +            parse_numa_node(ms, &node, NULL);  
> > I get build break here:
> >
> > numa.c:451:13: error: too few arguments to function ‘parse_numa_node’
> >              parse_numa_node(ms, &node, NULL);
> >  
> 
> In upstream tree, your commit
> 
>    cc001888b780 ("numa: fixup parsed NumaNodeOptions earlier")
> 
> removed a argument from parse_numa_node() recently. this definition
> of function becomes
> 
> static void parse_numa_node(MachineState *ms, NumaNodeOptions *node,
>                              Error **errp)
> 
> this patch is based on the upstream tree, parse_numa_node() should have
> three arguments.
> 
> I am not sure why you got this building failure log, can you tell me
> which branch did you test?
it looks like I've failed to update master branch and applied it to old master,
so after refetching and applying it again build and tests passes.

(Sorry for  noise :/)

> 
> Thanks,
> 	dou
> 
> 
>