From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <shajnocz@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <famz@redhat.com>,
Juan Quintela <quintela@redhat.com>,
mdroth@linux.vnet.ibm.com, peterx@redhat.com,
Eric Blake <eblake@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
marcandre.lureau@redhat.com,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: [Qemu-devel] [RFC v4 08/27] monitor: let mon_list be tail queue
Date: Thu, 16 Nov 2017 21:05:51 +0800 [thread overview]
Message-ID: <20171116130610.23582-9-peterx@redhat.com> (raw)
In-Reply-To: <20171116130610.23582-1-peterx@redhat.com>
It was QLIST. I want to use this list to do monitor priority job later,
which need tail insertion ability. So switching to a tail queue.
Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
monitor.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/monitor.c b/monitor.c
index ac5313023b..a70ab5606b 100644
--- a/monitor.c
+++ b/monitor.c
@@ -205,7 +205,7 @@ struct Monitor {
void *password_opaque;
mon_cmd_t *cmd_table;
QLIST_HEAD(,mon_fd_t) fds;
- QLIST_ENTRY(Monitor) entry;
+ QTAILQ_ENTRY(Monitor) entry;
};
/* QMP checker flags */
@@ -214,7 +214,7 @@ struct Monitor {
/* Protects mon_list, monitor_event_state. */
static QemuMutex monitor_lock;
-static QLIST_HEAD(mon_list, Monitor) mon_list;
+static QTAILQ_HEAD(mon_list, Monitor) mon_list;
static QLIST_HEAD(mon_fdsets, MonFdset) mon_fdsets;
static int mon_refcount;
@@ -415,7 +415,7 @@ static void monitor_qapi_event_emit(QAPIEvent event, QDict *qdict)
Monitor *mon;
trace_monitor_protocol_event_emit(event, qdict);
- QLIST_FOREACH(mon, &mon_list, entry) {
+ QTAILQ_FOREACH(mon, &mon_list, entry) {
if (monitor_is_qmp(mon)
&& mon->qmp.commands != &qmp_cap_negotiation_commands) {
monitor_json_emitter(mon, QOBJECT(qdict));
@@ -4118,8 +4118,8 @@ void monitor_cleanup(void)
Monitor *mon, *next;
qemu_mutex_lock(&monitor_lock);
- QLIST_FOREACH_SAFE(mon, &mon_list, entry, next) {
- QLIST_REMOVE(mon, entry);
+ QTAILQ_FOREACH_SAFE(mon, &mon_list, entry, next) {
+ QTAILQ_REMOVE(&mon_list, mon, entry);
monitor_data_destroy(mon);
g_free(mon);
}
--
2.13.6
next prev parent reply other threads:[~2017-11-16 13:07 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 13:05 [Qemu-devel] [RFC v4 00/27] QMP: out-of-band (OOB) execution support Peter Xu
2017-11-16 13:05 ` [Qemu-devel] [RFC v4 01/27] qobject: introduce qstring_get_try_str() Peter Xu
2017-11-16 13:05 ` [Qemu-devel] [RFC v4 02/27] qobject: introduce qobject_get_try_str() Peter Xu
2017-11-16 13:05 ` [Qemu-devel] [RFC v4 03/27] qobject: let object_property_get_str() use new API Peter Xu
2017-11-16 13:05 ` [Qemu-devel] [RFC v4 04/27] monitor: move skip_flush into monitor_data_init Peter Xu
2017-11-16 13:05 ` [Qemu-devel] [RFC v4 05/27] qjson: add "opaque" field to JSONMessageParser Peter Xu
2017-11-16 13:05 ` [Qemu-devel] [RFC v4 06/27] monitor: move the cur_mon hack deeper for QMP Peter Xu
2017-11-16 13:05 ` [Qemu-devel] [RFC v4 07/27] monitor: unify global init Peter Xu
2017-11-16 13:05 ` Peter Xu [this message]
2017-11-16 13:05 ` [Qemu-devel] [RFC v4 09/27] monitor: create monitor dedicate iothread Peter Xu
2017-11-23 10:46 ` Dr. David Alan Gilbert
2017-11-23 10:51 ` Dr. David Alan Gilbert
2017-11-23 10:53 ` Daniel P. Berrange
2017-11-24 7:36 ` Peter Xu
2017-11-16 13:05 ` [Qemu-devel] [RFC v4 10/27] monitor: allow to use IO thread for parsing Peter Xu
2017-11-16 13:05 ` [Qemu-devel] [RFC v4 11/27] qmp: introduce QMPCapability Peter Xu
2017-11-16 13:05 ` [Qemu-devel] [RFC v4 12/27] qmp: negociate QMP capabilities Peter Xu
2017-11-16 13:05 ` [Qemu-devel] [RFC v4 13/27] qmp: introduce some capability helpers Peter Xu
2017-11-16 13:05 ` [Qemu-devel] [RFC v4 14/27] monitor: introduce monitor_qmp_respond() Peter Xu
2017-11-16 13:05 ` [Qemu-devel] [RFC v4 15/27] monitor: let monitor_{suspend|resume} thread safe Peter Xu
2017-11-23 11:23 ` Dr. David Alan Gilbert
2017-11-24 7:58 ` Peter Xu
2017-11-16 13:05 ` [Qemu-devel] [RFC v4 16/27] monitor: separate QMP parser and dispatcher Peter Xu
2017-11-16 13:06 ` [Qemu-devel] [RFC v4 17/27] qmp: add new event "request-dropped" Peter Xu
2017-11-16 13:06 ` [Qemu-devel] [RFC v4 18/27] monitor: send event when request queue full Peter Xu
2017-11-16 13:06 ` [Qemu-devel] [RFC v4 19/27] qapi: introduce new cmd option "allow-oob" Peter Xu
2017-11-16 13:06 ` [Qemu-devel] [RFC v4 20/27] qmp: support out-of-band (oob) execution Peter Xu
2017-11-16 13:06 ` [Qemu-devel] [RFC v4 21/27] qmp: let migrate-incoming allow out-of-band Peter Xu
2017-11-24 13:14 ` Dr. David Alan Gilbert
2017-11-27 5:20 ` Peter Xu
2017-11-27 10:44 ` Dr. David Alan Gilbert
2017-11-27 10:54 ` Peter Xu
2017-11-27 11:04 ` Dr. David Alan Gilbert
2017-11-27 11:26 ` Peter Xu
2017-11-16 13:06 ` [Qemu-devel] [RFC v4 22/27] qmp: isolate responses into io thread Peter Xu
2017-11-16 13:06 ` [Qemu-devel] [RFC v4 23/27] monitor: enable IO thread for (qmp & !mux) typed Peter Xu
2017-11-24 11:01 ` Dr. David Alan Gilbert
2017-11-27 3:00 ` Peter Xu
2017-11-16 13:06 ` [Qemu-devel] [RFC v4 24/27] qmp: add command "x-oob-test" Peter Xu
2017-11-16 13:06 ` [Qemu-devel] [RFC v4 25/27] docs: update QMP documents for OOB commands Peter Xu
2017-11-16 13:06 ` [Qemu-devel] [RFC v4 26/27] tests: qmp-test: verify command batching Peter Xu
2017-11-16 13:06 ` [Qemu-devel] [RFC v4 27/27] tests: qmp-test: add oob test Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171116130610.23582-9-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=shajnocz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).