From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eFMnd-0002Yi-GM for qemu-devel@nongnu.org; Thu, 16 Nov 2017 11:14:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eFMnX-0007nk-KN for qemu-devel@nongnu.org; Thu, 16 Nov 2017 11:13:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46196) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eFMnX-0007ln-Db for qemu-devel@nongnu.org; Thu, 16 Nov 2017 11:13:51 -0500 Date: Thu, 16 Nov 2017 16:13:44 +0000 From: "Daniel P. Berrange" Message-ID: <20171116161344.GU16461@redhat.com> Reply-To: "Daniel P. Berrange" References: <1510769835-31902-1-git-send-email-mst@redhat.com> <20171116173033-mutt-send-email-mst@kernel.org> <20171116154534.GR16461@redhat.com> <20171116175149-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: "Michael S. Tsirkin" , QEMU Developers On Thu, Nov 16, 2017 at 04:10:22PM +0000, Peter Maydell wrote: > On 16 November 2017 at 15:56, Michael S. Tsirkin wrote: > > On Thu, Nov 16, 2017 at 03:45:34PM +0000, Daniel P. Berrange wrote: > >> On Thu, Nov 16, 2017 at 05:38:18PM +0200, Michael S. Tsirkin wrote: > >> > I think it's test: fix detection of errors from iasl > >> > I'll drop it for now. > >> > >> I think that patch is merely exposing a failure that has always > >> happened, but which we've never noticed before. So dropping that > >> patch just hides the error again, doesn't fix the error. > > > We shouldn't fail test if system can't load expected files. > > This just will trip up people trying to build qemu. > > If there are known-buggy iasl versions in the wild we could > consider a configure test and treat buggy-iasl like no-iasl. iasl has long been broken on big-endian, but it has also long contained code that simply makes it exit immediately in that case, and qemu copes with that. So if there's buggy iasl it would be a distro which removed this big-endian check and tried to make it work on big-endian but failed. Fedora tried the latter, but at least in rawhide it works properly now. I'm unclear if we shipped broken iasl with the BE check removed in stable versions though Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|