qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	Alexander Graf <agraf@suse.de>,
	David Hildenbrand <david@redhat.com>
Subject: [Qemu-devel] [PATCH v1 for-2.11 3/3] s390x/tcg: fix DIAG 308 with > 1 VCPU (MTTCG)
Date: Thu, 16 Nov 2017 18:05:26 +0100	[thread overview]
Message-ID: <20171116170526.12643-4-david@redhat.com> (raw)
In-Reply-To: <20171116170526.12643-1-david@redhat.com>

Currently, multi threaded TCG with > 1 VCPU gets stuck during IPL, when
the bios tries to switch to the loaded kernel via DIAG 308.

As run_on_cpu() is used, we run into a deadlock after handling the reset.
We need the iolock (just like KVM).

Signed-off-by: David Hildenbrand <david@redhat.com>
---
 target/s390x/misc_helper.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c
index 4afd90b969..d272851e1c 100644
--- a/target/s390x/misc_helper.c
+++ b/target/s390x/misc_helper.c
@@ -103,7 +103,9 @@ void HELPER(diag)(CPUS390XState *env, uint32_t r1, uint32_t r3, uint32_t num)
         break;
     case 0x308:
         /* ipl */
+        qemu_mutex_lock_iothread();
         handle_diag_308(env, r1, r3);
+        qemu_mutex_unlock_iothread();
         r = 0;
         break;
     case 0x288:
-- 
2.13.6

  parent reply	other threads:[~2017-11-16 17:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-16 17:05 [Qemu-devel] [PATCH v1 for-2.11 0/3] s390x: fixes for SIGP and DIAG 308 David Hildenbrand
2017-11-16 17:05 ` [Qemu-devel] [PATCH v1 for-2.11 1/3] s390x: fix storing CPU status (again) David Hildenbrand
2017-11-16 20:45   ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2017-11-16 20:58   ` [Qemu-devel] " Christian Borntraeger
2017-11-16 17:05 ` [Qemu-devel] [PATCH v1 for-2.11 2/3] s390x/tcg: fix DIAG 308 with > 1 VCPU (single threaded TCG) David Hildenbrand
2017-11-16 17:37   ` Alex Bennée
2017-11-16 17:52     ` David Hildenbrand
2017-11-16 18:12       ` Alex Bennée
2017-11-16 18:24         ` David Hildenbrand
2017-11-16 18:14       ` Alex Bennée
2017-11-16 17:47   ` David Hildenbrand
2017-11-16 20:57   ` Christian Borntraeger
2017-11-16 21:42     ` David Hildenbrand
2017-11-16 17:05 ` David Hildenbrand [this message]
2017-11-16 20:54   ` [Qemu-devel] [qemu-s390x] [PATCH v1 for-2.11 3/3] s390x/tcg: fix DIAG 308 with > 1 VCPU (MTTCG) Thomas Huth
2017-11-16 17:23 ` [Qemu-devel] [PATCH v1 for-2.11 0/3] s390x: fixes for SIGP and DIAG 308 Cornelia Huck
2017-11-16 17:32   ` David Hildenbrand
2017-11-16 20:55   ` Christian Borntraeger
2017-11-17  8:07     ` Cornelia Huck
2017-11-17  8:10   ` Cornelia Huck
2017-11-17  8:38     ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171116170526.12643-4-david@redhat.com \
    --to=david@redhat.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).