From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1
Date: Thu, 16 Nov 2017 18:15:24 +0200 [thread overview]
Message-ID: <20171116181158-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAFEAcA_DqWVaZ-oK8S9j9Hqu_AJ5nE2g9waf7Gd5vmeyKGZLsA@mail.gmail.com>
On Thu, Nov 16, 2017 at 04:10:22PM +0000, Peter Maydell wrote:
> On 16 November 2017 at 15:56, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Thu, Nov 16, 2017 at 03:45:34PM +0000, Daniel P. Berrange wrote:
> >> On Thu, Nov 16, 2017 at 05:38:18PM +0200, Michael S. Tsirkin wrote:
> >> > I think it's test: fix detection of errors from iasl
> >> > I'll drop it for now.
> >>
> >> I think that patch is merely exposing a failure that has always
> >> happened, but which we've never noticed before. So dropping that
> >> patch just hides the error again, doesn't fix the error.
>
> > We shouldn't fail test if system can't load expected files.
> > This just will trip up people trying to build qemu.
>
> If there are known-buggy iasl versions in the wild we could
> consider a configure test and treat buggy-iasl like no-iasl.
>
> thanks
> -- PMM
Right. All this is not 2.11 material though.
--
MST
prev parent reply other threads:[~2017-11-16 16:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 18:17 [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1 Michael S. Tsirkin
2017-11-15 18:17 ` [Qemu-devel] [PULL 01/10] fix: unrealize virtio device if we fail to hotplug it Michael S. Tsirkin
2017-11-15 18:17 ` [Qemu-devel] [PULL 02/10] pci: Initialize pci_dev->name before use Michael S. Tsirkin
2017-11-15 18:18 ` [Qemu-devel] [PULL 03/10] tests: report errors when iasl exits with non-zero status Michael S. Tsirkin
2017-11-15 18:18 ` [Qemu-devel] [PULL 04/10] test: fix detection of errors from iasl Michael S. Tsirkin
2017-11-15 18:18 ` [Qemu-devel] [PULL 05/10] hw/pci-host: Fix x86 Host Bridges 64bit PCI hole Michael S. Tsirkin
2017-11-15 18:18 ` [Qemu-devel] [PULL 06/10] hw/pcie-pci-bridge: restrict to X86 and ARM Michael S. Tsirkin
2017-11-15 18:18 ` [Qemu-devel] [PULL 07/10] tests/acpi-test-data: update _CRS in DSDT Michael S. Tsirkin
2017-11-15 18:18 ` [Qemu-devel] [PULL 08/10] NUMA: Enable adding NUMA node implicitly Michael S. Tsirkin
2017-11-16 10:22 ` Thadeu Lima de Souza Cascardo
2017-11-15 18:19 ` [Qemu-devel] [PULL 09/10] vmcoreinfo: put it in the 'misc' device category Michael S. Tsirkin
2017-11-15 18:19 ` [Qemu-devel] [PULL 10/10] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets Michael S. Tsirkin
2017-11-16 14:41 ` [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1 Peter Maydell
2017-11-16 15:19 ` Thomas Huth
2017-11-16 15:38 ` Michael S. Tsirkin
2017-11-16 15:45 ` Daniel P. Berrange
2017-11-16 15:56 ` Michael S. Tsirkin
2017-11-16 16:10 ` Peter Maydell
2017-11-16 16:13 ` Daniel P. Berrange
2017-11-16 16:15 ` Peter Maydell
2017-11-16 16:43 ` Thomas Huth
2017-11-17 4:24 ` Michael S. Tsirkin
2017-11-16 16:15 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171116181158-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=berrange@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).