From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: mst@redhat.com, yuri.benditovich@daynix.com, yvugenfi@redhat.com,
jasowang@redhat.com, qemu-devel@nongnu.org
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: [Qemu-devel] [PATCH 0/2] virtio-net: Fix TX data discard on backend disconnection
Date: Thu, 16 Nov 2017 19:48:33 +0100 [thread overview]
Message-ID: <20171116184835.28556-1-maxime.coquelin@redhat.com> (raw)
This series fixes TX data discard when backend disconnects.
On backend disconnection, QEMU cannot retrieve its internal
avail index, which makes the virtio queue internal state
inconsistent (last_avail_idx will always be 0, whereas used_idx
is correct).
It results in discarding TX data to corrupt the vring state, by
completing descriptors already completed by the backend.
This series fixes this by restoring last_avail_idx to the vring
used idx, as some backends used to do on reconnection.
Maxime Coquelin (2):
virtio: Add queue interface to restore avail index from vring used
index
vhost: restore avail index from vring used index on disconnection
hw/virtio/vhost.c | 4 ++++
hw/virtio/virtio.c | 10 ++++++++++
include/hw/virtio/virtio.h | 1 +
3 files changed, 15 insertions(+)
--
2.14.3
next reply other threads:[~2017-11-16 18:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 18:48 Maxime Coquelin [this message]
2017-11-16 18:48 ` [Qemu-devel] [PATCH 1/2] virtio: Add queue interface to restore avail index from vring used index Maxime Coquelin
2017-11-17 9:15 ` Jens Freimann
2017-11-16 18:48 ` [Qemu-devel] [PATCH 2/2] vhost: restore avail index from vring used index on disconnection Maxime Coquelin
2017-11-17 9:14 ` Jens Freimann
2017-11-17 4:01 ` [Qemu-devel] [PATCH 0/2] virtio-net: Fix TX data discard on backend disconnection Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171116184835.28556-1-maxime.coquelin@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yuri.benditovich@daynix.com \
--cc=yvugenfi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).