From: Jens Freimann <jfreimann@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: mst@redhat.com, yuri.benditovich@daynix.com, yvugenfi@redhat.com,
jasowang@redhat.com, qemu-devel@nongnu.org,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] vhost: restore avail index from vring used index on disconnection
Date: Fri, 17 Nov 2017 10:14:14 +0100 [thread overview]
Message-ID: <20171117091414.y57oguzv2jruobdd@dhcp-192-218.str.redhat.com> (raw)
In-Reply-To: <20171116184835.28556-3-maxime.coquelin@redhat.com>
On Thu, Nov 16, 2017 at 06:48:35PM +0000, Maxime Coquelin wrote:
>vhost_virtqueue_stop() gets avail index value from the backend,
>except if the backend is not responding.
>
>It happens when the backend crashes, and in this case, internal
>state of the virtio queue is inconsistent, making packets
>to corrupt the vring state.
>
>With a Linux guest, it results in following error message on
>backend reconnection:
>
>[ 22.444905] virtio_net virtio0: output.0:id 0 is not a head!
>[ 22.446746] net enp0s3: Unexpected TXQ (0) queue failure: -5
>[ 22.476360] net enp0s3: Unexpected TXQ (0) queue failure: -5
>
>Fixes: 283e2c2adcb8 ("net: virtio-net discards TX data after link down")
>Cc: qemu-stable@nongnu.org
>Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>---
> hw/virtio/vhost.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
Reviewed-by: Jens Freimann <jfreimann@redhat.com>
next prev parent reply other threads:[~2017-11-17 9:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 18:48 [Qemu-devel] [PATCH 0/2] virtio-net: Fix TX data discard on backend disconnection Maxime Coquelin
2017-11-16 18:48 ` [Qemu-devel] [PATCH 1/2] virtio: Add queue interface to restore avail index from vring used index Maxime Coquelin
2017-11-17 9:15 ` Jens Freimann
2017-11-16 18:48 ` [Qemu-devel] [PATCH 2/2] vhost: restore avail index from vring used index on disconnection Maxime Coquelin
2017-11-17 9:14 ` Jens Freimann [this message]
2017-11-17 4:01 ` [Qemu-devel] [PATCH 0/2] virtio-net: Fix TX data discard on backend disconnection Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171117091414.y57oguzv2jruobdd@dhcp-192-218.str.redhat.com \
--to=jfreimann@redhat.com \
--cc=jasowang@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=yuri.benditovich@daynix.com \
--cc=yvugenfi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).