From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59327) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eFi7j-0001LQ-1L for qemu-devel@nongnu.org; Fri, 17 Nov 2017 10:00:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eFi7f-0007LE-5A for qemu-devel@nongnu.org; Fri, 17 Nov 2017 10:00:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60760) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eFi7e-0007KD-Uv for qemu-devel@nongnu.org; Fri, 17 Nov 2017 10:00:03 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B02AC1A4070 for ; Fri, 17 Nov 2017 15:00:01 +0000 (UTC) Date: Fri, 17 Nov 2017 14:59:54 +0000 From: "Daniel P. Berrange" Message-ID: <20171117145954.GX25830@redhat.com> Reply-To: "Daniel P. Berrange" References: <20171117103046.15943-1-kraxel@redhat.com> <20171117103046.15943-2-kraxel@redhat.com> <20171117142130.GU25830@redhat.com> <20171117144906.4z36tvqclc2gah2d@sirius.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20171117144906.4z36tvqclc2gah2d@sirius.home.kraxel.org> Subject: Re: [Qemu-devel] [PATCH 01/24] sdl: remove -no-frame support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org, Paolo Bonzini , Markus Armbruster On Fri, Nov 17, 2017 at 03:49:06PM +0100, Gerd Hoffmann wrote: > On Fri, Nov 17, 2017 at 02:21:30PM +0000, Daniel P. Berrange wrote: > > On Fri, Nov 17, 2017 at 11:30:23AM +0100, Gerd Hoffmann wrote: > > > SDL2 doesn't support this any more, the SDL_NOFRAME window flag is gone. > > > Drop the code, print a notice when the option is still used. > > > > > > Signed-off-by: Gerd Hoffmann > > > --- > > > include/ui/console.h | 5 ++--- > > > ui/sdl.c | 8 +------- > > > ui/sdl2.c | 7 +------ > > > vl.c | 15 ++++----------- > > > 4 files changed, 8 insertions(+), 27 deletions(-) > > > > This needs to go through the deprecation process before we can > > drop it. There's still time to get it into 2.11 deprecated list > > which would cut the time needed to wait for real deletion. > > I fail to see the point. SDL2 simply doesn't support it, so it never > worked with SDL2. We switched to SDL2 as default recently. So it seems > fair to me to just say so instead of silently ignoring the option ... We still support SDL don't we, which does support it, and which this option was targetted at ? Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|