qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Programmingkid <programmingkidx@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	Markus Armbruster <armbru@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 02/24] sdl: remove -alt-grab and -ctrl-grab support
Date: Fri, 17 Nov 2017 22:14:12 +0100	[thread overview]
Message-ID: <20171117211412.ar4d4z52um2uq7c7@sirius.home.kraxel.org> (raw)
In-Reply-To: <50461419-2FB0-4A94-A6E6-4EFB459FF39D@gmail.com>

On Fri, Nov 17, 2017 at 11:06:12AM -0500, Programmingkid wrote:
> 
> > With absolute pointer devices such as usb-tablet being widely used
> > mouse grabs (for relative pointing devices) should be rarely needed
> > these days.  So the benefit of the options to configure the hotkey
> > modifiers for grab (and other actions) seems questionable.  Which
> > is expecially true for the -ctrl-grab which isn't handled in the
> > handle_keyup() code.
> 
> So does this mean you are against a patch that would allow the user to
> chose a key to act as a mouse ungrab key?

I don't consider it a top priority, and given there I have lots of other
things to do I most likely wouldn't implement that.  But I wouldn't
object if someone comes up with a sane implementation.

What we have right now is just a big mess though, both in code and the
user interface.  First, these are toplevel command line options.  It
belongs to -display though.  Second, it's two hard-coded names for two
hard-coded variations.  So it's not like you can configure much.  On top
of that the names are not exactly intuitive.  And it works with SDL only.

cheers,
  Gerd

  reply	other threads:[~2017-11-17 21:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.8273.1510914667.27993.qemu-devel@nongnu.org>
2017-11-17 16:06 ` [Qemu-devel] [PATCH 02/24] sdl: remove -alt-grab and -ctrl-grab support Programmingkid
2017-11-17 21:14   ` Gerd Hoffmann [this message]
2017-11-17 10:30 [Qemu-devel] [PATCH 00/24] RfC: rework display initialization Gerd Hoffmann
2017-11-17 10:30 ` [Qemu-devel] [PATCH 02/24] sdl: remove -alt-grab and -ctrl-grab support Gerd Hoffmann
2017-11-17 14:22   ` Daniel P. Berrange
2017-11-17 14:51     ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171117211412.ar4d4z52um2uq7c7@sirius.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=programmingkidx@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).