From: Zhong Yang <yang.zhong@intel.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com,
weidong.huang@huawei.com, arei.gonglei@huawei.com,
liujunjie23@huawei.com, wangxinxin.wang@huawei.com,
stone.xulei@huawei.com, anthony.xu@intel.com,
stefanha@redhat.com, zhang.zhanghailiang@huawei.com,
yang.zhong@intel.com
Subject: Re: [Qemu-devel] [PATCH] rcu: reduce half heap memory size by malloc_trim()
Date: Tue, 21 Nov 2017 11:12:08 +0800 [thread overview]
Message-ID: <20171121031208.GA8063@yangzhon-Virtual> (raw)
In-Reply-To: <20171120142828.GB6828@lemon.lan>
On Mon, Nov 20, 2017 at 10:28:28PM +0800, Fam Zheng wrote:
> On Fri, 11/17 14:23, Yang Zhong wrote:
> > diff --git a/util/rcu.c b/util/rcu.c
> > index ca5a63e..8d491a6 100644
> > --- a/util/rcu.c
> > +++ b/util/rcu.c
> > @@ -26,6 +26,7 @@
> > * IBM's contributions to this file may be relicensed under LGPLv2 or later.
> > */
> >
> > +#include <malloc.h>
>
> BTW, if you respin, the "qemu/osdep.h" header should always be included first as
> per HACKING file.
Hello Fam,
Thanks for your reminder!
I ever thought the header file include in Qemu like linux kernel did, thanks again!
Regards,
Yang
prev parent reply other threads:[~2017-11-21 3:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 6:23 [Qemu-devel] [PATCH] rcu: reduce half heap memory size by malloc_trim() Yang Zhong
2017-11-17 13:54 ` Stefan Hajnoczi
2017-11-17 14:06 ` Daniel P. Berrange
2017-11-20 8:54 ` Zhong Yang
2017-11-20 14:14 ` Daniel P. Berrange
2017-11-21 5:46 ` Zhong Yang
2017-11-20 8:41 ` Zhong Yang
2017-11-20 14:03 ` Stefan Hajnoczi
2017-11-21 3:20 ` Zhong Yang
2017-11-20 14:28 ` Fam Zheng
2017-11-21 3:12 ` Zhong Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121031208.GA8063@yangzhon-Virtual \
--to=yang.zhong@intel.com \
--cc=anthony.xu@intel.com \
--cc=arei.gonglei@huawei.com \
--cc=famz@redhat.com \
--cc=liujunjie23@huawei.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=stone.xulei@huawei.com \
--cc=wangxinxin.wang@huawei.com \
--cc=weidong.huang@huawei.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).