From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
Jeff Cody <jcody@redhat.com>,
qemu-devel@nongnu.org, famz@redhat.com, qemu-block@nongnu.org,
mreitz@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 1/5] blockjob: do not allow coroutine double entry or entry-after-completion
Date: Tue, 21 Nov 2017 13:42:09 +0100 [thread overview]
Message-ID: <20171121124209.GA11073@localhost.localdomain> (raw)
In-Reply-To: <b910238b-d42c-abfe-9d57-1db2c97728cc@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 738 bytes --]
Am 20.11.2017 um 23:25 hat Paolo Bonzini geschrieben:
> On 20/11/2017 12:16, Stefan Hajnoczi wrote:
> > This raises questions about the ability to cancel sleep:
> >
> > 1. Does something depend on cancelling sleep?
>
> block_job_cancel does, but in practice the sleep time is so small
> (smaller than SLICE_TIME, which is 100 ms) that we probably don't care.
Just note that this is something that can happen during the final
migration phase when the VM is already stopped. In other words, with
non-shared storage, these up to 100 ms are added to the migration
downtime.
Kevin
> I agree with Jeff that canceling the sleep by force-entering the
> coroutine seemed clever but is probably a very bad idea.
>
> Paolo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-11-21 12:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 2:46 [Qemu-devel] [PATCH 0/5] Fix segfault in blockjob race condition Jeff Cody
2017-11-20 2:46 ` [Qemu-devel] [PATCH 1/5] blockjob: do not allow coroutine double entry or entry-after-completion Jeff Cody
2017-11-20 11:16 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-11-20 13:36 ` Jeff Cody
2017-11-21 10:47 ` Stefan Hajnoczi
2017-11-20 22:25 ` Paolo Bonzini
2017-11-21 12:42 ` Kevin Wolf [this message]
2017-11-20 2:46 ` [Qemu-devel] [PATCH 2/5] coroutine: abort if we try to enter coroutine scheduled for another ctx Jeff Cody
2017-11-20 11:28 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-11-20 13:42 ` Jeff Cody
2017-11-20 2:46 ` [Qemu-devel] [PATCH 3/5] coroutines: abort if we try to enter a still-sleeping coroutine Jeff Cody
2017-11-20 11:43 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-11-20 13:45 ` Jeff Cody
2017-11-21 10:17 ` Stefan Hajnoczi
2017-11-20 22:30 ` [Qemu-devel] " Paolo Bonzini
2017-11-20 22:35 ` Jeff Cody
2017-11-20 22:47 ` Paolo Bonzini
2017-11-20 23:08 ` Jeff Cody
2017-11-20 23:13 ` Paolo Bonzini
2017-11-20 23:31 ` Jeff Cody
2017-11-20 2:46 ` [Qemu-devel] [PATCH 4/5] qemu-iotests: add option in common.qemu for mismatch only Jeff Cody
2017-11-20 2:46 ` [Qemu-devel] [PATCH 5/5] qemu-iotest: add test for blockjob coroutine race condition Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121124209.GA11073@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).