From: Tao Wu <lepton@google.com>
To: qemu-devel@nongnu.org
Cc: kraxel@redhat.com, Tao Wu <lepton@google.com>
Subject: [Qemu-devel] [PATCH] hw/input/hid: Fix some wrong hid usage mappings.
Date: Tue, 21 Nov 2017 13:43:50 -0800 [thread overview]
Message-ID: <20171121214350.55138-1-lepton@google.com> (raw)
There are some wrong hid usage mapping in hid_usage_keys table.
It can be confirmed with "sendkey" command in monitor and verify
the behavior in guest OS.
This CL fixed some wrong hid usage mapping for these keys:
kp_equals kp_comma audiomute volumedown volumeup power
There still are some wrong mapping left in hid_usage_keys table, but
they are not as important as above keys. The list of left buggy keys:
open paste ro hiragana henkan yen again props undo front audioprev audionext
calculator audioplay audiostop cut find sleep ac_refresh stop ac_forward
ac_back help copy
Signed-off-by: Tao Wu <lepton@google.com>
---
hw/input/hid.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/input/hid.c b/hw/input/hid.c
index 0d049ff61c..08a0f07bbf 100644
--- a/hw/input/hid.c
+++ b/hw/input/hid.c
@@ -47,24 +47,24 @@ static const uint8_t hid_usage_keys[0x100] = {
0x3f, 0x40, 0x41, 0x42, 0x43, 0x53, 0x47, 0x5f,
0x60, 0x61, 0x56, 0x5c, 0x5d, 0x5e, 0x57, 0x59,
0x5a, 0x5b, 0x62, 0x63, 0x46, 0x00, 0x64, 0x44,
- 0x45, 0x68, 0x69, 0x6a, 0x6b, 0x6c, 0x6d, 0x6e,
+ 0x45, 0x67, 0x69, 0x6a, 0x6b, 0x6c, 0x6d, 0x6e,
0xe8, 0xe9, 0x71, 0x72, 0x73, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x85, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
- 0x00, 0x00, 0x00, 0x00, 0x00, 0xe3, 0xe7, 0x65,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0xe3, 0x85, 0x65,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x58, 0xe4, 0x00, 0x00,
- 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
- 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
- 0x00, 0x00, 0x00, 0x00, 0x00, 0x54, 0x00, 0x46,
+ 0x7f, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x81, 0x00,
+ 0x80, 0x00, 0x00, 0x00, 0x00, 0x54, 0x00, 0x46,
0xe6, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x48, 0x48, 0x4a,
0x52, 0x4b, 0x00, 0x50, 0x00, 0x4f, 0x00, 0x4d,
0x51, 0x4e, 0x49, 0x4c, 0x00, 0x00, 0x00, 0x00,
- 0x00, 0x00, 0x00, 0xe3, 0xe7, 0x65, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0xe3, 0xe7, 0x65, 0x66, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
--
2.15.0.448.gf294e3d99a-goog
next reply other threads:[~2017-11-21 21:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 21:43 Tao Wu [this message]
2017-11-21 22:18 ` [Qemu-devel] [PATCH] hw/input/hid: Fix some wrong hid usage mappings no-reply
2017-11-21 22:42 ` Tao Wu(吴涛@Eng)
2017-11-28 17:31 ` Tao Wu(吴涛@Eng)
2017-12-05 3:42 ` Tao Wu(吴涛@Eng)
2017-12-07 6:58 ` Tao Wu(吴涛@Eng)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121214350.55138-1-lepton@google.com \
--to=lepton@google.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).