From: "Michael S. Tsirkin" <mst@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
linux-kernel@vger.kernel.org, somlo@cmu.edu,
xiaolong.ye@intel.com, qemu-devel@nongnu.org,
"Andrew Morton" <akpm@linux-foundation.org>,
"Baoquan He" <bhe@redhat.com>, "Dave Young" <dyoung@redhat.com>,
"Hari Bathini" <hbathini@linux.vnet.ibm.com>,
"Tony Luck" <tony.luck@intel.com>,
"Vivek Goyal" <vgoyal@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v8 4/5] crash: export paddr_vmcoreinfo_note()
Date: Fri, 24 Nov 2017 06:20:35 +0200 [thread overview]
Message-ID: <20171124061759-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20171123143657.GA19971@infradead.org>
On Thu, Nov 23, 2017 at 06:36:57AM -0800, Christoph Hellwig wrote:
> On Thu, Nov 23, 2017 at 03:02:05PM +0100, Marc-André Lureau wrote:
> > The following patch is going to use the symbol from the fw_cfg module,
> > to call the function and write the note location details in the
> > vmcoreinfo entry, so qemu can produce dumps with the vmcoreinfo note.
>
> Sounds like fw_cfg should be moved to be built in only instead of
> exporting such a symbol address.
Point is, all fw cfg does is export it on to the hypervisor, so it will
have to be supported forever. If it's safe to export it to the
hypervisor then for sure it's also safe to export it to modules.
--
MST
next prev parent reply other threads:[~2017-11-24 4:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 14:02 [Qemu-devel] [PATCH v8 0/5] fw_cfg: add DMA operations & etc/vmcoreinfo support Marc-André Lureau
2017-11-23 14:02 ` [Qemu-devel] [PATCH v8 1/5] fw_cfg: fix driver remove Marc-André Lureau
2017-11-23 14:02 ` [Qemu-devel] [PATCH v8 2/5] fw_cfg: add DMA register Marc-André Lureau
2017-11-23 14:02 ` [Qemu-devel] [PATCH v8 3/5] fw_cfg: do DMA read operation Marc-André Lureau
2017-12-01 15:14 ` Michael S. Tsirkin
2017-11-23 14:02 ` [Qemu-devel] [PATCH v8 4/5] crash: export paddr_vmcoreinfo_note() Marc-André Lureau
2017-11-23 14:36 ` Christoph Hellwig
2017-11-24 4:20 ` Michael S. Tsirkin [this message]
2017-11-23 14:02 ` [Qemu-devel] [PATCH v8 5/5] fw_cfg: write vmcoreinfo details Marc-André Lureau
2017-11-29 1:23 ` [Qemu-devel] [PATCH v8 0/5] fw_cfg: add DMA operations & etc/vmcoreinfo support Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171124061759-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=hbathini@linux.vnet.ibm.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=somlo@cmu.edu \
--cc=tony.luck@intel.com \
--cc=vgoyal@redhat.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).