qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Francisco Iglesias <frasse.iglesias@gmail.com>
To: qemu-devel@nongnu.org
Cc: edgari@xilinx.com, alistai@xilinx.com,
	francisco.iglesias@feimtech.se, mar.krzeminski@gmail.com,
	peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH v8 11/13] xilinx_spips: Don't set TX FIFO UNDERFLOW at cmd done
Date: Fri, 24 Nov 2017 22:29:36 +0100	[thread overview]
Message-ID: <20171124212938.7074-12-frasse.iglesias@gmail.com> (raw)
In-Reply-To: <20171124212938.7074-1-frasse.iglesias@gmail.com>

Don't set TX FIFO UNDERFLOW interrupt after transmitting the commands.
Also update interrupts after reading out the interrupt status.

Signed-off-by: Francisco Iglesias <frasse.iglesias@gmail.com>
Acked-by: Alistair Francis <alistair.francis@xilinx.com>
---
 hw/ssi/xilinx_spips.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c
index ab54da8..3805d8b 100644
--- a/hw/ssi/xilinx_spips.c
+++ b/hw/ssi/xilinx_spips.c
@@ -329,9 +329,6 @@ static void xilinx_spips_flush_txfifo(XilinxSPIPS *s)
         uint8_t addr_length;
 
         if (fifo8_is_empty(&s->tx_fifo)) {
-            if (!(s->regs[R_LQSPI_CFG] & LQSPI_CFG_LQ_MODE)) {
-                s->regs[R_INTR_STATUS] |= IXR_TX_FIFO_UNDERFLOW;
-            }
             xilinx_spips_update_ixr(s);
             return;
         } else if (s->snoop_state == SNOOP_STRIPING) {
@@ -530,6 +527,7 @@ static uint64_t xilinx_spips_read(void *opaque, hwaddr addr,
         ret = s->regs[addr] & IXR_ALL;
         s->regs[addr] = 0;
         DB_PRINT_L(0, "addr=" TARGET_FMT_plx " = %x\n", addr * 4, ret);
+        xilinx_spips_update_ixr(s);
         return ret;
     case R_INTR_MASK:
         mask = IXR_ALL;
-- 
2.9.3

  parent reply	other threads:[~2017-11-24 21:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-24 21:29 [Qemu-devel] [PATCH v8 00/13] Add support for the ZynqMP Generic QSPI Francisco Iglesias
2017-11-24 21:29 ` [Qemu-devel] [PATCH v8 01/13] m25p80: Add support for continuous read out of RDSR and READ_FSR Francisco Iglesias
2017-11-24 21:29 ` [Qemu-devel] [PATCH v8 02/13] m25p80: Add support for SST READ ID 0x90/0xAB commands Francisco Iglesias
2017-11-26  0:45   ` Philippe Mathieu-Daudé
2017-11-26 22:20     ` francisco iglesias
2017-11-24 21:29 ` [Qemu-devel] [PATCH v8 03/13] m25p80: Add support for BRRD/BRWR and BULK_ERASE (0x60) Francisco Iglesias
2017-11-24 21:29 ` [Qemu-devel] [PATCH v8 04/13] m25p80: Add support for n25q512a11 and n25q512a13 Francisco Iglesias
2017-11-24 21:29 ` [Qemu-devel] [PATCH v8 05/13] xilinx_spips: Move FlashCMD, XilinxQSPIPS and XilinxSPIPSClass Francisco Iglesias
2017-11-26  0:48   ` Philippe Mathieu-Daudé
2017-11-24 21:29 ` [Qemu-devel] [PATCH v8 06/13] xilinx_spips: Update striping to be big-endian bit order Francisco Iglesias
2017-11-24 21:29 ` [Qemu-devel] [PATCH v8 07/13] xilinx_spips: Add support for RX discard and RX drain Francisco Iglesias
2017-11-24 21:29 ` [Qemu-devel] [PATCH v8 08/13] xilinx_spips: Make tx/rx_data_bytes more generic and reusable Francisco Iglesias
2017-11-24 21:29 ` [Qemu-devel] [PATCH v8 09/13] xilinx_spips: Add support for zero pumping Francisco Iglesias
2017-11-24 21:29 ` [Qemu-devel] [PATCH v8 10/13] xilinx_spips: Add support for 4 byte addresses in the LQSPI Francisco Iglesias
2017-11-24 21:29 ` Francisco Iglesias [this message]
2017-11-24 21:29 ` [Qemu-devel] [PATCH v8 12/13] xilinx_spips: Add support for the ZynqMP Generic QSPI Francisco Iglesias
2017-11-24 21:29 ` [Qemu-devel] [PATCH v8 13/13] xlnx-zcu102: Add support for the ZynqMP QSPI Francisco Iglesias
2017-11-24 22:51 ` [Qemu-devel] [PATCH v8 00/13] Add support for the ZynqMP Generic QSPI Edgar E. Iglesias
2017-11-25 18:48   ` francisco iglesias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171124212938.7074-12-frasse.iglesias@gmail.com \
    --to=frasse.iglesias@gmail.com \
    --cc=alistai@xilinx.com \
    --cc=edgari@xilinx.com \
    --cc=francisco.iglesias@feimtech.se \
    --cc=mar.krzeminski@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).