Re: [Qemu-devel] [Qemu-block] [PATCH v5 for-2.11] QAPI & interop: Clarify events emitted by 'block-job-cancel'

[Kevin Wolf <kwolf@redhat.com>]

Am 27.11.2017 um 14:00 hat Kashyap Chamarthy geschrieben:
> On Mon, Nov 27, 2017 at 12:53:07PM +0100, Kevin Wolf wrote:
> > Am 21.11.2017 um 12:52 hat Kashyap Chamarthy geschrieben:
> 
> [...]
> 
> > > Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
> > > Reviewed-by: Eric Blake <eblake@redhat.com>
> > 
> > > +(1) Issuing the command ``block-job-cancel`` (after it emits the event
> > > +    ``BLOCK_JOB_COMPLETED``) will create a point-in-time (which is at
> > > +    the time of *triggering* the cancel command) copy of the entire disk
> > >      image chain (or only the top-most image, depending on the ``sync``
> > > -    mode).
> > > +    mode), contained in the target image [E]. One use case for this is
> > > +    live storage migration.
> > 
> > As commented on v4, 
> 
> You're right, I agree with your comment on v4.
> 
> > I dropped the last sentence here for now. Please
> > suggest an unambiguous wording if you'd prefer to keep it.
> 
> If you can still add, and are happy with it, please go with the less
> ambiguous wording: "One use case for this is live VM migration with
> non-shared storage".
> 
> Just that I feel it immediately gives the use case in context.

Ok, I'll change it accordingly.

Kevin