From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJUSB-0001SU-EL for qemu-devel@nongnu.org; Mon, 27 Nov 2017 20:12:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJUS8-0004kK-92 for qemu-devel@nongnu.org; Mon, 27 Nov 2017 20:12:51 -0500 Date: Mon, 27 Nov 2017 23:12:43 -0200 From: Eduardo Habkost Message-ID: <20171128011243.GE3037@localhost.localdomain> References: <20171125151610.20547-1-ehabkost@redhat.com> <20171125151610.20547-4-ehabkost@redhat.com> <20171127015209.GB11775@umbus.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171127015209.GB11775@umbus.fritz.box> Subject: Re: [Qemu-devel] [PATCH v2 3/6] ppc: e500: Allow only supported dynamic sysbus devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-devel@nongnu.org, jgross@suse.com, Thomas Huth , sstabellini@kernel.org, Laszlo Ersek , Marcel Apfelbaum , Alexander Graf , qemu-ppc@nongnu.org On Mon, Nov 27, 2017 at 12:52:09PM +1100, David Gibson wrote: > On Sat, Nov 25, 2017 at 01:16:07PM -0200, Eduardo Habkost wrote: > > platform_bus_create_devtree() already rejects all dynamic sysbus > > devices except TYPE_ETSEC_COMMON, so register it as the only > > allowed dynamic sysbus device for the ppce500 machine-type. > > > > Cc: Alexander Graf > > Cc: David Gibson > > Cc: qemu-ppc@nongnu.org > > Signed-off-by: Eduardo Habkost > > Acked-by: David Gibson Thanks! > > Do you need me to take this through my tree (for 2.12), or do you have > another merge patch in mind? As this patch requires patch 1/6 to be applied first and there are patches touching other machines in this series, I can merge this through my machine core tree if you don't mind. > > > --- > > Changes series v1 -> v2: > > * New patch added to series > > --- > > hw/ppc/e500plat.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/hw/ppc/e500plat.c b/hw/ppc/e500plat.c > > index 438118c29b..81d03e1038 100644 > > --- a/hw/ppc/e500plat.c > > +++ b/hw/ppc/e500plat.c > > @@ -12,6 +12,7 @@ > > #include "qemu/osdep.h" > > #include "qemu-common.h" > > #include "e500.h" > > +#include "hw/net/fsl_etsec/etsec.h" > > #include "hw/boards.h" > > #include "sysemu/device_tree.h" > > #include "sysemu/kvm.h" > > @@ -64,8 +65,7 @@ static void e500plat_machine_init(MachineClass *mc) > > mc->desc = "generic paravirt e500 platform"; > > mc->init = e500plat_init; > > mc->max_cpus = 32; > > - /*TODO: allow only sysbus devices that really work with this machine */ > > - machine_class_allow_dynamic_sysbus_dev(mc, TYPE_SYS_BUS_DEVICE); > > + machine_class_allow_dynamic_sysbus_dev(mc, TYPE_ETSEC_COMMON); > > mc->default_cpu_type = POWERPC_CPU_TYPE_NAME("e500v2_v30"); > > } > > > > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson -- Eduardo