From: Kevin Wolf <kwolf@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Max Reitz <mreitz@redhat.com>, Jeff Cody <jcody@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.11] blockjob: Remove the job from the list earlier in block_job_unref()
Date: Tue, 28 Nov 2017 16:59:51 +0100 [thread overview]
Message-ID: <20171128155951.GD3703@localhost.localdomain> (raw)
In-Reply-To: <w51bmjm762e.fsf@maestria.local.igalia.com>
Am 28.11.2017 um 16:53 hat Alberto Garcia geschrieben:
> On Tue 28 Nov 2017 03:53:27 PM CET, Alberto Garcia wrote:
> > When destroying a block job in block_job_unref() we should remove it
> > from the job list before calling block_job_remove_all_bdrv().
> >
> > This is because removing the BDSs can trigger an aio_poll() and wake
> > up other jobs that might attempt to use the block job list. If that
> > happens the job we're currently destroying should not be in that list
> > anymore.
> > ---
> > blockjob.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I forgot this
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2017-11-28 16:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 14:53 [Qemu-devel] [PATCH for-2.11] blockjob: Remove the job from the list earlier in block_job_unref() Alberto Garcia
2017-11-28 15:53 ` Alberto Garcia
2017-11-28 15:59 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128155951.GD3703@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=berto@igalia.com \
--cc=jcody@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).