From: Kevin Wolf <kwolf@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
John Snow <jsnow@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for 2.11 0/2] QEMU crashes with CD device without media
Date: Tue, 28 Nov 2017 17:08:05 +0100 [thread overview]
Message-ID: <20171128160805.GE3703@localhost.localdomain> (raw)
In-Reply-To: <20171128121055.6954-1-den@openvz.org>
Am 28.11.2017 um 13:10 hat Denis V. Lunev geschrieben:
> There are 2 cases I have spotted so far:
> 1) IDE ATAPI read processing. Actually this was reported from field
> 2) QEMU IO hmp command (found during evaluation of (1))
>
> SCSI code checks during access that blk_is_available(). These patches add
> same checks on different code paths.
>
> Pls decide whether these patches should go through sub-system trees or via
> block tree.
Why does this always come up in the last minute? :-(
The real fix shouldn't be in the devices, but blk_aio_*() needs to
handle empty drives gracefully. We already made a similar fix before the
last release in commit 4da97120d, and I already didn't like it back
then.
Of course, we should have used the time to fix this properly, but as you
can see, nothing has happened and we're running out of time again.
Kevin
next prev parent reply other threads:[~2017-11-28 16:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 12:10 [Qemu-devel] [PATCH for 2.11 0/2] QEMU crashes with CD device without media Denis V. Lunev
2017-11-28 12:10 ` [Qemu-devel] [PATCH 1/2] hmp: block qemu-io command for " Denis V. Lunev
2017-11-30 16:22 ` Stefan Hajnoczi
2017-11-28 12:10 ` [Qemu-devel] [PATCH 2/2] ide: fix crash in IDE cdrom read Denis V. Lunev
2017-11-28 16:56 ` Kevin Wolf
2017-11-28 17:26 ` Denis V. Lunev
2017-11-28 23:50 ` John Snow
2017-11-30 12:01 ` Denis V. Lunev
2017-12-12 23:40 ` John Snow
2017-12-14 11:29 ` Denis V. Lunev
2017-12-18 17:49 ` John Snow
2018-01-24 10:25 ` Denis V. Lunev
2017-11-28 16:08 ` Kevin Wolf [this message]
2017-11-28 16:29 ` [Qemu-devel] [PATCH for 2.11 0/2] QEMU crashes with CD device without media Denis V. Lunev
2017-11-28 17:01 ` John Snow
2017-11-28 17:28 ` Peter Maydell
2017-11-28 18:40 ` Denis V. Lunev
2017-12-11 10:24 ` Denis V. Lunev
2017-12-11 18:26 ` John Snow
2018-03-13 17:18 ` John Snow
2018-03-13 17:25 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128160805.GE3703@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=den@openvz.org \
--cc=dgilbert@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).